HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38004 )
Change subject: src/{soc,southbridge}/amd: Fix typo ......................................................................
src/{soc,southbridge}/amd: Fix typo
Change-Id: I7e3dc64648af05d51a319019397f24ba74c25c37 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/common/block/alink/alink.c M src/southbridge/amd/agesa/hudson/smbus.c M src/southbridge/amd/pi/hudson/smbus.c 3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/38004/1
diff --git a/src/soc/amd/common/block/alink/alink.c b/src/soc/amd/common/block/alink/alink.c index f481f6b..f80d769 100644 --- a/src/soc/amd/common/block/alink/alink.c +++ b/src/soc/amd/common/block/alink/alink.c @@ -36,7 +36,7 @@ // printk(BIOS_DEBUG, "about write %x, index=%x", tmp, // (reg_space&0x3)<<29 | reg_addr);
- /* probably we dont have to do it again. */ + /* probably we don't have to do it again. */ outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); outl(tmp, AB_DATA); outl(0, AB_INDX); @@ -60,7 +60,7 @@ //printk(BIOS_DEBUG, "about write %x, index=%x", tmp, // (reg_space&0x3)<<29 | (port&3) << 24 | reg_addr);
- /* probably we dont have to do it again. */ + /* probably we don't have to do it again. */ outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); outl(tmp, AB_DATA); outl(0, AB_INDX); diff --git a/src/southbridge/amd/agesa/hudson/smbus.c b/src/southbridge/amd/agesa/hudson/smbus.c index 783c324..bc985e2 100644 --- a/src/southbridge/amd/agesa/hudson/smbus.c +++ b/src/southbridge/amd/agesa/hudson/smbus.c @@ -189,7 +189,7 @@ tmp |= val;
/* printk(BIOS_DEBUG, "about write %x, index=%x", tmp, (reg_space&0x3)<<29 | reg_addr); */ - outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we dont have to do it again. */ + outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ outl(tmp, AB_DATA); outl(0, AB_INDX); } @@ -211,7 +211,7 @@ tmp |= val;
//printk(BIOS_DEBUG, "about write %x, index=%x", tmp, (reg_space&0x3)<<29 | (port&3) << 24 | reg_addr); - outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we dont have to do it again. */ + outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ outl(tmp, AB_DATA); outl(0, AB_INDX); } diff --git a/src/southbridge/amd/pi/hudson/smbus.c b/src/southbridge/amd/pi/hudson/smbus.c index 783c324..bc985e2 100644 --- a/src/southbridge/amd/pi/hudson/smbus.c +++ b/src/southbridge/amd/pi/hudson/smbus.c @@ -189,7 +189,7 @@ tmp |= val;
/* printk(BIOS_DEBUG, "about write %x, index=%x", tmp, (reg_space&0x3)<<29 | reg_addr); */ - outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we dont have to do it again. */ + outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ outl(tmp, AB_DATA); outl(0, AB_INDX); } @@ -211,7 +211,7 @@ tmp |= val;
//printk(BIOS_DEBUG, "about write %x, index=%x", tmp, (reg_space&0x3)<<29 | (port&3) << 24 | reg_addr); - outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we dont have to do it again. */ + outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ outl(tmp, AB_DATA); outl(0, AB_INDX); }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38004 )
Change subject: src/{soc,southbridge}/amd: Fix typo ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38004/1/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/smbus.c:
https://review.coreboot.org/c/coreboot/+/38004/1/src/southbridge/amd/agesa/h... PS1, Line 192: outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38004/1/src/southbridge/amd/agesa/h... PS1, Line 214: outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38004/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/smbus.c:
https://review.coreboot.org/c/coreboot/+/38004/1/src/southbridge/amd/pi/huds... PS1, Line 192: outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38004/1/src/southbridge/amd/pi/huds... PS1, Line 214: outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ line over 96 characters
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38004 )
Change subject: src/{soc,southbridge}/amd: Fix typo ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38004/1/src/soc/amd/common/block/al... File src/soc/amd/common/block/alink/alink.c:
https://review.coreboot.org/c/coreboot/+/38004/1/src/soc/amd/common/block/al... PS1, Line 37: // (reg_space&0x3)<<29 | reg_addr); Can you push followup to remove some of these commented code segments
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38004 )
Change subject: src/{soc,southbridge}/amd: Fix typo ......................................................................
src/{soc,southbridge}/amd: Fix typo
Change-Id: I7e3dc64648af05d51a319019397f24ba74c25c37 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38004 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/amd/common/block/alink/alink.c M src/southbridge/amd/agesa/hudson/smbus.c M src/southbridge/amd/pi/hudson/smbus.c 3 files changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/soc/amd/common/block/alink/alink.c b/src/soc/amd/common/block/alink/alink.c index f481f6b..f80d769 100644 --- a/src/soc/amd/common/block/alink/alink.c +++ b/src/soc/amd/common/block/alink/alink.c @@ -36,7 +36,7 @@ // printk(BIOS_DEBUG, "about write %x, index=%x", tmp, // (reg_space&0x3)<<29 | reg_addr);
- /* probably we dont have to do it again. */ + /* probably we don't have to do it again. */ outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); outl(tmp, AB_DATA); outl(0, AB_INDX); @@ -60,7 +60,7 @@ //printk(BIOS_DEBUG, "about write %x, index=%x", tmp, // (reg_space&0x3)<<29 | (port&3) << 24 | reg_addr);
- /* probably we dont have to do it again. */ + /* probably we don't have to do it again. */ outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); outl(tmp, AB_DATA); outl(0, AB_INDX); diff --git a/src/southbridge/amd/agesa/hudson/smbus.c b/src/southbridge/amd/agesa/hudson/smbus.c index 783c324..bc985e2 100644 --- a/src/southbridge/amd/agesa/hudson/smbus.c +++ b/src/southbridge/amd/agesa/hudson/smbus.c @@ -189,7 +189,7 @@ tmp |= val;
/* printk(BIOS_DEBUG, "about write %x, index=%x", tmp, (reg_space&0x3)<<29 | reg_addr); */ - outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we dont have to do it again. */ + outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ outl(tmp, AB_DATA); outl(0, AB_INDX); } @@ -211,7 +211,7 @@ tmp |= val;
//printk(BIOS_DEBUG, "about write %x, index=%x", tmp, (reg_space&0x3)<<29 | (port&3) << 24 | reg_addr); - outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we dont have to do it again. */ + outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ outl(tmp, AB_DATA); outl(0, AB_INDX); } diff --git a/src/southbridge/amd/pi/hudson/smbus.c b/src/southbridge/amd/pi/hudson/smbus.c index 783c324..bc985e2 100644 --- a/src/southbridge/amd/pi/hudson/smbus.c +++ b/src/southbridge/amd/pi/hudson/smbus.c @@ -189,7 +189,7 @@ tmp |= val;
/* printk(BIOS_DEBUG, "about write %x, index=%x", tmp, (reg_space&0x3)<<29 | reg_addr); */ - outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we dont have to do it again. */ + outl((reg_space & 0x7) << 29 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ outl(tmp, AB_DATA); outl(0, AB_INDX); } @@ -211,7 +211,7 @@ tmp |= val;
//printk(BIOS_DEBUG, "about write %x, index=%x", tmp, (reg_space&0x3)<<29 | (port&3) << 24 | reg_addr); - outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we dont have to do it again. */ + outl((reg_space & 0x7) << 29 | (port & 3) << 24 | reg_addr, AB_INDX); /* probably we don't have to do it again. */ outl(tmp, AB_DATA); outl(0, AB_INDX); }
-
build bot (Jenkins) (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)