Change in coreboot[master]: google/trogdor: Add backlight support for Parade ps8640 - coreboot-gerrit

1 Nov 2021


      Attention is currently required from: Philip Chen, Douglas Anderson, Julius Werner.
Xuxin Xiong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58624 )
Change subject: google/trogdor: Add backlight support for Parade ps8640
......................................................................
Patch Set 8:
(1 comment)
File src/drivers/parade/ps8640/ps8640.c:
https://review.coreboot.org/c/coreboot/+/58624/comment/251dbf59_4a491c8e 
PS7, Line 159: 		}
...
Ack
For with ps8640 bridge, we didn't need to operate more than 16 bytes, so we didn't test this. With TI bridge, it will use this interface to read EDID, more than 16 bytes, and it looks like work normal.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58624
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief1bf56c89c8215427dcbddfc67e8bcd4c3607d2
Gerrit-Change-Number: 58624
Gerrit-PatchSet: 8
Gerrit-Owner: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Douglas Anderson dianders@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Philip Chen philipchen@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Philip Chen philipchen@google.com
Gerrit-Attention: Philip Chen philipchen@google.com
Gerrit-Attention: Douglas Anderson dianders@chromium.org
Gerrit-Attention: Philip Chen philipchen@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Mon, 01 Nov 2021 08:24:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-MessageType: comment