Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30721
Change subject: mb/google/sarien: Enable recovery mode GPIO ......................................................................
mb/google/sarien: Enable recovery mode GPIO
Enable the active-low recovery mode GPIO now that new boards are available which have an external pull-up instead of a pull-down so it can be asserted properly by servo.
This was tested on a Sarien system by holding the recovery button on the servo board and tapping the cold reset button and ensuring that it enters recovery mode.
Change-Id: I3216580bc94de71b05bf9382f15d0c4d428cb9fa Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/google/sarien/variants/sarien/gpio.c 1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/30721/1
diff --git a/src/mainboard/google/sarien/variants/sarien/gpio.c b/src/mainboard/google/sarien/variants/sarien/gpio.c index 3f43e73..f773265 100644 --- a/src/mainboard/google/sarien/variants/sarien/gpio.c +++ b/src/mainboard/google/sarien/variants/sarien/gpio.c @@ -252,10 +252,7 @@ }
static const struct cros_gpio cros_gpios[] = { - /* - * TODO: re-enable recovery mode when boards are updated: - * CROS_GPIO_REC_AL(GPP_E8, CROS_GPIO_DEVICE_NAME), - */ + CROS_GPIO_REC_AL(GPP_E8, CROS_GPIO_DEVICE_NAME), CROS_GPIO_WP_AH(GPP_E15, CROS_GPIO_DEVICE_NAME), };