Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38887 )
Change subject: vboot: remove use of NEED_VB20_INTERNALS switch ......................................................................
vboot: remove use of NEED_VB20_INTERNALS switch
The NEED_VB20_INTERNALS switch is being deprecated. Use the header file vb2_internals_please_do_not_use.h instead.
BUG=b:124141368, chromium:957880 TEST=make clean && make test-abuild BRANCH=none
Change-Id: Ie35644876178b806fab4f0ce8089a556227312db Signed-off-by: Joel Kitching kitching@google.com Cq-Depend: chromium:2055600 --- M src/vendorcode/eltan/security/verified_boot/vboot_check.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/38887/1
diff --git a/src/vendorcode/eltan/security/verified_boot/vboot_check.c b/src/vendorcode/eltan/security/verified_boot/vboot_check.c index 2edd8f9..9d99e02 100644 --- a/src/vendorcode/eltan/security/verified_boot/vboot_check.c +++ b/src/vendorcode/eltan/security/verified_boot/vboot_check.c @@ -14,13 +14,12 @@ * GNU General Public License for more details. */
-#define NEED_VB20_INTERNALS - #include <boot_device.h> #include <bootmem.h> #include <cbfs.h> #include <vboot_check.h> #include <vboot_common.h> +#include <vb2_internals_please_do_not_use.h>
#define RSA_PUBLICKEY_FILE_NAME "vboot_public_key.bin"
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38887 )
Change subject: vboot: remove use of NEED_VB20_INTERNALS switch ......................................................................
Patch Set 1: Code-Review+2
You need a vboot uprev somewhere, I think.
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38887 )
Change subject: vboot: remove use of NEED_VB20_INTERNALS switch ......................................................................
Patch Set 2:
Patch Set 1: Code-Review+2
You need a vboot uprev somewhere, I think.
Waiting on https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_referen... to merge and then coreboot.org vboot uprev.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38887 )
Change subject: vboot: remove use of NEED_VB20_INTERNALS switch ......................................................................
vboot: remove use of NEED_VB20_INTERNALS switch
The NEED_VB20_INTERNALS switch is being deprecated. Use the header file vb2_internals_please_do_not_use.h instead.
BUG=b:124141368, chromium:957880 TEST=make clean && make test-abuild BRANCH=none
Change-Id: Ie35644876178b806fab4f0ce8089a556227312db Signed-off-by: Joel Kitching kitching@google.com Cq-Depend: chromium:2055600 Reviewed-on: https://review.coreboot.org/c/coreboot/+/38887 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/vendorcode/eltan/security/verified_boot/vboot_check.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/vendorcode/eltan/security/verified_boot/vboot_check.c b/src/vendorcode/eltan/security/verified_boot/vboot_check.c index 2edd8f9..9d99e02 100644 --- a/src/vendorcode/eltan/security/verified_boot/vboot_check.c +++ b/src/vendorcode/eltan/security/verified_boot/vboot_check.c @@ -14,13 +14,12 @@ * GNU General Public License for more details. */
-#define NEED_VB20_INTERNALS - #include <boot_device.h> #include <bootmem.h> #include <cbfs.h> #include <vboot_check.h> #include <vboot_common.h> +#include <vb2_internals_please_do_not_use.h>
#define RSA_PUBLICKEY_FILE_NAME "vboot_public_key.bin"
-
Joel Kitching (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)