Attention is currently required from: Arthur Heymans, Felix Held.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76523?usp=email )
Change subject: soc/amd/genoa: Hook SMP and SMM init ......................................................................
Patch Set 5:
(4 comments)
File src/soc/amd/genoa/include/soc/nvs.h:
PS4:
would be good to also split this into a separate patch and add the corresponding asl file in the sam […]
Done
File src/soc/amd/genoa/include/soc/nvs.h:
https://review.coreboot.org/c/coreboot/+/76523/comment/9c4e5e1d_5688189b : PS2, Line 18: uint8_t unused_was_pcnt; /* 0x00 - Processor Count */ : uint8_t lids; /* 0x01 - LID State */ : uint8_t unused_was_pwrs; /* 0x02 - AC Power State */ : uint32_t cbmc; /* 0x03 - 0x06 - coreboot Memory Console */
those are likely not needed or used any more. this must still match the corresponding . […]
Done
https://review.coreboot.org/c/coreboot/+/76523/comment/0acc17f8_738ba485 : PS2, Line 24: uint8_t tmps; /* 0x17 - Temperature Sensor ID */ : uint8_t tcrt; /* 0x18 - Critical Threshold */ : uint8_t tpsv; /* 0x19 - Passive Threshold */
likely also unused
Done
File src/soc/amd/genoa/include/soc/smu.h:
PS4:
i'd factor out this one into a separate patch that the also selects the smu kconfig option
Done