Change in coreboot[master]: mb/prodrive/hermes: Drop Vref configuration for older boards - coreboot-gerrit

1 Apr 2021


      Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/51919/comment/23503071_8dd57ff0 
PS1, Line 42: 		return AZALIA_PIN_DESC(
...
The driver won't detect a valid pin configuration when AZALIA_PIN_DESC is used. […]
Which hex value should be used here? I suspect the values in the AZALIA_PIN_DESC macro aren't correct.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c207f97dad6c9107c1999eb46d2d6304a6c217
Gerrit-Change-Number: 51919
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Justin van Son justin.van.son@prodrive-technologies.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Justin van Son justin.van.son@prodrive-technologies.com
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Comment-Date: Thu, 01 Apr 2021 07:44:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son justin.van.son@prodrive-technologies.com
Gerrit-MessageType: comment