Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Nicholas Chin, Paul Menzel.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/86390?usp=email )
Change subject: sb/intel/common: Add GPIO serial blink console support ......................................................................
Patch Set 3:
(6 comments)
Patchset:
PS3: I'm no native English speaker either, so I ran the text through an online grammar checker.
File Documentation/technotes/console.md:
https://review.coreboot.org/c/coreboot/+/86390/comment/9313f0d0_f342e0c3?usp... : PS2, Line 177: a LED
an LED
Done
https://review.coreboot.org/c/coreboot/+/86390/comment/5f6d360c_00da7cbb?usp... : PS2, Line 178: pulls
pull (without s)?
Done
https://review.coreboot.org/c/coreboot/+/86390/comment/e761be04_6bdaf574?usp... : PS2, Line 182:
No space.
Done
https://review.coreboot.org/c/coreboot/+/86390/comment/4e5f9243_8083b433?usp... : PS2, Line 183: to base your circuit off of
Sounds strange, but I am no native speaker.
Done
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/86390/comment/e212ac7a_30232b08?usp... : PS2, Line 405: an
a
Done