Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Patrick Rudolph.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80337?usp=email )
Change subject: cpu/x86: Link page tables in stage if possible ......................................................................
Patch Set 13:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80337/comment/3773cb17_b24a76da : PS13, Line 9: 32 to 64 32-bits to 64-bits
https://review.coreboot.org/c/coreboot/+/80337/comment/46c7a653_c0cbcd98 : PS13, Line 9: back and forward "backward and forward" or "back and forth"
https://review.coreboot.org/c/coreboot/+/80337/comment/880d9488_72e3021e : PS13, Line 10: 32bit 32-bits
https://review.coreboot.org/c/coreboot/+/80337/comment/f42b6f06_5ba2f66b : PS13, Line 10: tables table
https://review.coreboot.org/c/coreboot/+/80337/comment/b2d43d87_6030a74e : PS13, Line 14: cbfs CBFS
https://review.coreboot.org/c/coreboot/+/80337/comment/00fee421_180d06fe : PS13, Line 22: used using
https://review.coreboot.org/c/coreboot/+/80337/comment/950c871a_7d611817 : PS13, Line 26: cbfs CBFS
https://review.coreboot.org/c/coreboot/+/80337/comment/8bbd1313_e93e1bfa : PS13, Line 28: TESTED TEST: <...>
File src/cpu/x86/64bit/pt.S:
https://review.coreboot.org/c/coreboot/+/80337/comment/81401ba9_72063394 : PS13, Line 21: .align 4096 wouldn't it make sense to change the alignment depending on the configuration to prevent waste of space when page tables are in CBFS ?