Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59612 )
Change subject: sc7280: Add support for edp driver & mdp driver ......................................................................
Patch Set 3: Verified-1
(118 comments)
File src/mainboard/google/herobrine/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/6321e57a_3464477c PS3, Line 63: if (display_init_required()) { suspect code indent for conditional statements (8, 24)
File src/soc/qualcomm/sc7280/display/edp_aux.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/f0ab0821_44100df0 PS3, Line 99: printk(BIOS_ERR,"%s: invalid size or buffer \n",__func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/3029d194_6bc37886 PS3, Line 99: printk(BIOS_ERR,"%s: invalid size or buffer \n",__func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/f5fd23f9_be95ab56 PS3, Line 99: printk(BIOS_ERR,"%s: invalid size or buffer \n",__func__); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/74dd3d2c_84466456 PS3, Line 106: printk(BIOS_ERR,"%s: invalid msg: size(%zu), request(%x)\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/641e6d17_ddbaeeae PS3, Line 113: printk(BIOS_ERR,"edp aux transfer tx failed\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/fa1b3fa6_2dcfedb0 PS3, Line 115: if (read) { suspect code indent for conditional statements (8, 24)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/db6b1146_7f8e7a6b PS3, Line 118: printk(BIOS_ERR,"edp aux transfer rx failed\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/5e1997d0_edccdb84 PS3, Line 138: if (err <EDID_LENGTH) { spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/42b732fc_c60e5386 PS3, Line 139: printk(BIOS_ERR, "ERROR: Failed to read EDID. :0x%x\n",err); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/9b1dc81b_28839c05 PS3, Line 148: if (err>0) spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/19ae266d_40b402a2 PS3, Line 149: err = edp_aux_transfer(EDID_I2C_ADDR, DP_AUX_I2C_READ, &edid[EDID_LENGTH], line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/d820e92b_b9b17aa7 PS3, Line 151: if (err<EDID_LENGTH) { spaces required around that '<' (ctx:VxV)
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/02354cb0_9379e7ba PS3, Line 405: static void edp_link_train_clock_recovery_delay(const uint8_t dpcd[DP_RECEIVER_CAP_SIZE]) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/b26697d3_01fe9b22 PS3, Line 409: printk(BIOS_ERR,"AUX interval %d, out of range (max 4)\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/3e87c496_3a125662 PS3, Line 426: if ((lane_status & DP_LANE_CR_DONE) == 0) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/a4ce3b65_3c8e383c PS3, Line 428: printk(BIOS_ERR,"clock recovery ok failed : %x\n", lane_status); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/0725755b_6b2a48e3 PS3, Line 435: static void edp_link_train_channel_eq_delay(const uint8_t dpcd[DP_RECEIVER_CAP_SIZE]) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/d6c70eb7_1a6864ae PS3, Line 440: printk(BIOS_INFO,"AUX interval %d, out of range (max 4)\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/31ea86e6_5176a469 PS3, Line 471: write32(&edp_ahbclk->interrupt_status,EDP_INTERRUPT_STATUS1_MASK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/ef0f9bd2_4c258729 PS3, Line 490: if (dpcd[DP_EDP_CONFIGURATION_CAP] & DP_ALTERNATE_SCRAMBLER_RESET_CAP) suspect code indent for conditional statements (8, 10)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/fed1db08_8a422f8a PS3, Line 539: if (edp_aux_transfer(DP_TRAINING_LANE0_SET, DP_AUX_NATIVE_WRITE, buf, 2) <2) { spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/4b019697_89ae03cb PS3, Line 540: printk(BIOS_ERR,"%s: Set sw/pe to panel failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/65dbfaa9_da2a9691 PS3, Line 551: printk(BIOS_INFO,"pattern=%x\n", p); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/bd41d518_8c3204fd PS3, Line 553: printk(BIOS_ERR,"%s: Set training pattern to panel failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/b8f2fba1_5b43f3b3 PS3, Line 570: printk(BIOS_INFO,"lane=%d req_voltage_swing=0x%x\n", i, data); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/fc0de6f1_097b167e PS3, Line 581: printk(BIOS_INFO,"lane=%d req_pre_emphasis=0x%x\n", i, data); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/a9b5be74_218f6c30 PS3, Line 587: printk(BIOS_INFO,"v_level=%d, p_level=%d\n", ctrl->v_level, ctrl->p_level); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/2333c05b_7fbc99fc PS3, Line 596: printk(BIOS_INFO,"train=%d", train); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/563ea136_a7ea2297 PS3, Line 606: printk(BIOS_INFO,"%s: set link_train=%u failed\n", __func__, data); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/0dd57366_cd61af4f PS3, Line 611: printk(BIOS_INFO,"v=%d p=%d\n", ctrl->v_level, ctrl->p_level); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/a36b4a92_a0c7e70d PS3, Line 643: printk(BIOS_ERR,"%s: read link status failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/0a924e11_ef7b3388 PS3, Line 698: printk(BIOS_ERR,"%s: read link status failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/a4135433_30869b99 PS3, Line 746: printk(BIOS_INFO,"new rate=0x%x\n", ctrl->link_rate_khz); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/89f5c925_901790c3 PS3, Line 809: if (edp_aux_transfer(DP_LINK_BW_SET, DP_AUX_NATIVE_WRITE, &values[0], 1)< 0) spaces required around that '<' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/a5957c0e_c3a9f265 PS3, Line 830: printk(BIOS_ERR,"%s: read link status failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/37075ff2_5d83677a PS3, Line 836: printk(BIOS_ERR,"link reconfig\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/fab615d0_205a0662 PS3, Line 839: if (edp_clock_recovery_reduced_lanes(link_status, ctrl->lane_cnt) == 0) { line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/d3a46917_b8594e9d PS3, Line 841: printk(BIOS_ERR,"%s: Training 1 failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/0c80ec9b_ab48d240 PS3, Line 844: printk(BIOS_ERR,"link reconfig\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/dd746f8b_8c5ed441 PS3, Line 848: printk(BIOS_ERR,"%s: Training 1 failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/d7734753_a206a15f PS3, Line 855: printk(BIOS_INFO,"Training 1 completed successfully\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/7f247553_51b4e2e6 PS3, Line 858: if (edp_clear_training_pattern(dpcd)) suspect code indent for conditional statements (8, 10)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/2a7efbcc_9ec8f582 PS3, Line 859: return EDP_TRAIN_FAIL; Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/3b243cd5_7b0d02af PS3, Line 861: ret = edp_start_link_train_2(ctrl,dpcd); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/e9cefe80_75b39885 PS3, Line 866: printk(BIOS_ERR,"%s: read link status failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/527f0cb4_0c15a0ae PS3, Line 872: printk(BIOS_ERR,"link reconfig\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/4da6d962_9c056b8b PS3, Line 875: printk(BIOS_ERR,"%s: Training 2 failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/1642c609_c1d33121 PS3, Line 880: printk(BIOS_ERR,"%s: Training 1 failed\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/aa4d6b8c_529e2aaf PS3, Line 883: printk(BIOS_ERR,"link reconfig\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/4774862d_aa7722c6 PS3, Line 892: printk(BIOS_INFO,"Training 2 completed successfully\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/76e586d2_4a1b8f8a PS3, Line 971: printk(BIOS_ERR,"Invalid pixel mux divider\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/3bce1551_a2c4154b PS3, Line 982: printk(BIOS_INFO,"num=0x%x, den=0x%x\n", *pixel_m, *pixel_n); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/a276201a_a9136509 PS3, Line 997: if (DP_LINK_BW_5_4 == rate) Comparisons should place the constant on the right side of the test
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/3cf89c66_9c0de921 PS3, Line 1000: if (DP_LINK_BW_8_1 == rate) Comparisons should place the constant on the right side of the test
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/a5273cb9_6f7b8b31 PS3, Line 1003: printk(BIOS_INFO,"mvid=0x%x, nvid=0x%x\n", mvid, nvid); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/2a4206dd_cd76cd89 PS3, Line 1020: tu->last_partial_tu_fp =(tu->n_remainder_symbols_per_lane_fp / tu->tu_size); spaces required around that '=' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/0d1f19d9_30084c2a PS3, Line 1098: if (tu->new_err_fp <tu->diff_abs_fp) spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/ea5b2a85_ef3f5d35 PS3, Line 1115: int64_t temp =0; spaces required around that '=' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/5ffc0dc4_d22bef92 PS3, Line 1116: int64_t temp_fp =0; spaces required around that '=' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/4bc4aa12_e4fc3388 PS3, Line 1136: if (((tu->lwidth % tu->nlanes) != 0) && (tu->ratio_fp < f)) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/8f8e6eb4_6f364680 PS3, Line 1142: tu->err_fp = 1000 * f ; space prohibited before semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/7deff4e3_430d1016 PS3, Line 1143: if (tu->ratio_fp > f) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/7ddb9d06_c99f7c48 PS3, Line 1147: for (tu->tu_size = 32; tu->tu_size <= 64; tu->tu_size++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/8ade95d1_f1a19ab5 PS3, Line 1154: if(tu->new_err_fp < tu->err_fp) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/6892e7d0_9897fee7 PS3, Line 1154: if(tu->new_err_fp < tu->err_fp) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/cad15ae3_d0a75f66 PS3, Line 1256: printk(BIOS_ERR,"TU: valid_boundary_link: %d\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/f04b5020_6efb2086 PS3, Line 1258: printk(BIOS_ERR,"TU: delay_start_link: %d\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/2d8d8464_f822f89c PS3, Line 1260: printk(BIOS_ERR,"TU: boundary_moderation_en: %d\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/2bb9ff39_997678b0 PS3, Line 1262: printk(BIOS_ERR,"TU: valid_lower_boundary_link: %d\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/e356a7fa_549a4e7c PS3, Line 1264: printk(BIOS_ERR,"TU: upper_boundary_count: %d\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/25e7cf42_7e315246 PS3, Line 1266: printk(BIOS_ERR,"TU: lower_boundary_count: %d\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/1fac38b9_dc058ea2 PS3, Line 1268: printk(BIOS_ERR,"TU: tu_size_minus1: %d\n", tu_table->tu_size_minus1); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/d8b46f92_eb4fc38c PS3, Line 1275: edp_ctrl_calc_tu( ctrl, edid, &tu_config); space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/56ce6a97_e11635f7 PS3, Line 1320: data |= (0x1) ; space prohibited before semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/5281dbff_3cfd7cd5 PS3, Line 1346: static void edp_ctrl_link_enable(struct edp_ctrl* ctrl, "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/8951ae34_9066919b PS3, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/ffb6ae4d_c7db8b8a PS3, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/e513d0f1_8eab3217 PS3, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/724af12f_02de9ba7 PS3, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/3d79b117_d990f45c PS3, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/6b49f96d_5980619d PS3, Line 1366: mdss_clock_configure(MDSS_CLK_EDP_LINK,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/74bfe322_34ab1207 PS3, Line 1368: if(ret !=0) spaces required around that '!=' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/742b693f_3c201088 PS3, Line 1368: if(ret !=0) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/83f65330_b38dfaaa PS3, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/4194931f_922ca458 PS3, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/71a32159_4ab19255 PS3, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/bb11b4d9_f2666de4 PS3, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/79d37641_3bbe7894 PS3, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/64bcfc33_fc33598e PS3, Line 1371: mdss_clock_configure(MDSS_CLK_EDP_LINK_INTF,0,1,0,0,0,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/13ea8c57_f581b721 PS3, Line 1373: if(ret !=0) spaces required around that '!=' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/21c6c309_27198f7a PS3, Line 1373: if(ret !=0) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/3b71eac6_f0a5c053 PS3, Line 1379: if(ret !=0) spaces required around that '!=' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/131c3f27_4efd8f68 PS3, Line 1379: if(ret !=0) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/646171a4_1ae90858 PS3, Line 1394: while(ret == EDP_TRAIN_RECONFIG) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/ff6e1552_3945f488 PS3, Line 1396: edp_ctrl_irq_enable( 0); space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/bc2ac529_7cb63680 PS3, Line 1400: edp_ctrl_irq_enable( 1); space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/4a600266_5378b89e PS3, Line 1417: printk(BIOS_ERR,"ERROR: edp native read failure\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/b9bf1b57_80b682e8 PS3, Line 1424: printk(BIOS_ERR,"ERROR: edp native read failure\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/0e3f7669_5a151145 PS3, Line 1434: edp_ctrl_irq_enable( 1); space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/0286f8aa_b9575c8a PS3, Line 1439: printk(BIOS_ERR,"ERROR: edp training failure\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/32df7aa4_c143884b PS3, Line 1466: printk(BIOS_ERR,"%s: AUX channel is NOT ready\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/2ca4701a_fa5bc11d PS3, Line 1477: int ret =0; spaces required around that '=' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/9a6190d7_55637628 PS3, Line 1485: if(edp_read_edid(edid) == 0) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/00e9c2c5_306c0554 PS3, Line 1485: if(edp_read_edid(edid) == 0) space required before the open parenthesis '('
File src/soc/qualcomm/sc7280/display/edp_phy_7nm.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/ac9bd021_eda3598a PS3, Line 45: printk(BIOS_ERR,"%s: refgen not ready : 0x%x\n", __func__,read32(&edp_phy_pll->qserdes_com_cmn_status)); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/987e77f6_752cefbd PS3, Line 45: printk(BIOS_ERR,"%s: refgen not ready : 0x%x\n", __func__,read32(&edp_phy_pll->qserdes_com_cmn_status)); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/64c979dc_dab00c05 PS3, Line 45: printk(BIOS_ERR,"%s: refgen not ready : 0x%x\n", __func__,read32(&edp_phy_pll->qserdes_com_cmn_status)); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/dd3fcaab_4a9e08ca PS3, Line 214: printk(BIOS_ERR,"%s: Invalid link rate. rate = %u\n", __func__, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/edb42d7a_e000ae01 PS3, Line 281: printk(BIOS_ERR,"%s: Invalid link rate. rate = %u\n", __func__, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/86e291ca_65912608 PS3, Line 293: printk(BIOS_ERR,"%s: PLL not locked. Status\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/18c6489d_131d0c4e PS3, Line 301: printk(BIOS_ERR,"%s: PHY not ready. Status\n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/2b8edbb4_dfd1efd7 PS3, Line 309: printk(BIOS_ERR,"%s: PLL not locked. Status\n", __func__); space required after that ',' (ctx:VxV)
File src/soc/qualcomm/sc7280/display/mdss.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/7640fda8_9ae705d7 PS3, Line 55: printk(BIOS_ERR,"%s: \n", __func__); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/774955b9_adeefde3 PS3, Line 55: printk(BIOS_ERR,"%s: \n", __func__); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/d5696e21_46f8f19a PS3, Line 213: mdss_clock_configure(MDSS_CLK_MDP, 300 * MHz, 0, 0, 0 , 0 , 0 ); space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/cb19bb57_cb4b43b6 PS3, Line 213: mdss_clock_configure(MDSS_CLK_MDP, 300 * MHz, 0, 0, 0 , 0 , 0 ); space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134461): https://review.coreboot.org/c/coreboot/+/59612/comment/2c8d51aa_7a830eb1 PS3, Line 213: mdss_clock_configure(MDSS_CLK_MDP, 300 * MHz, 0, 0, 0 , 0 , 0 ); space prohibited before that close parenthesis ')'
-
build bot (Jenkins) (Code Review)