HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32821
Change subject: src/cpu: Use 'include <stdlib.h>' when appropriate ......................................................................
src/cpu: Use 'include <stdlib.h>' when appropriate
Change-Id: I44346594bc106eed73a1268b82f026b69e5f4512 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/allwinner/a10/clock.c M src/cpu/amd/family_10h-family_15h/init_cpus.h M src/cpu/intel/haswell/finalize.c M src/cpu/intel/model_2065x/finalize.c M src/cpu/intel/model_206ax/finalize.c M src/cpu/ti/am335x/gpio.c M src/cpu/ti/am335x/uart.c M src/cpu/x86/mtrr/mtrr.c 8 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/32821/1
diff --git a/src/cpu/allwinner/a10/clock.c b/src/cpu/allwinner/a10/clock.c index 76198b7..9e4e93d 100644 --- a/src/cpu/allwinner/a10/clock.c +++ b/src/cpu/allwinner/a10/clock.c @@ -22,7 +22,6 @@ #include <console/console.h> #include <delay.h> #include <lib.h> -#include <stdlib.h>
static struct a10_ccm *const ccm = (void *)A1X_CCM_BASE;
diff --git a/src/cpu/amd/family_10h-family_15h/init_cpus.h b/src/cpu/amd/family_10h-family_15h/init_cpus.h index 5d653d1..cca0049 100644 --- a/src/cpu/amd/family_10h-family_15h/init_cpus.h +++ b/src/cpu/amd/family_10h-family_15h/init_cpus.h @@ -16,7 +16,6 @@ #ifndef INIT_CPUS_H #define INIT_CPUS_H
-#include <stdlib.h> #include <cpu/x86/lapic.h> #include <cpu/x86/mtrr.h> #include <cpu/amd/msr.h> diff --git a/src/cpu/intel/haswell/finalize.c b/src/cpu/intel/haswell/finalize.c index cc2d1a4..16e54d7 100644 --- a/src/cpu/intel/haswell/finalize.c +++ b/src/cpu/intel/haswell/finalize.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <arch/cpu.h> #include <cpu/x86/msr.h> #include "haswell.h" diff --git a/src/cpu/intel/model_2065x/finalize.c b/src/cpu/intel/model_2065x/finalize.c index 5b85601..724e09c 100644 --- a/src/cpu/intel/model_2065x/finalize.c +++ b/src/cpu/intel/model_2065x/finalize.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <arch/cpu.h> #include <cpu/x86/msr.h> #include <cpu/intel/speedstep.h> diff --git a/src/cpu/intel/model_206ax/finalize.c b/src/cpu/intel/model_206ax/finalize.c index 30b00bb..98ce555 100644 --- a/src/cpu/intel/model_206ax/finalize.c +++ b/src/cpu/intel/model_206ax/finalize.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <arch/cpu.h> #include <cpu/x86/msr.h> #include <cpu/intel/speedstep.h> diff --git a/src/cpu/ti/am335x/gpio.c b/src/cpu/ti/am335x/gpio.c index 2685839..8660f2c 100644 --- a/src/cpu/ti/am335x/gpio.c +++ b/src/cpu/ti/am335x/gpio.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <cpu/ti/am335x/gpio.h> #include <stdint.h> -#include <stdlib.h>
static struct am335x_gpio_regs *gpio_regs_and_bit(unsigned int gpio, uint32_t *bit) diff --git a/src/cpu/ti/am335x/uart.c b/src/cpu/ti/am335x/uart.c index c482a85..4e9d012 100644 --- a/src/cpu/ti/am335x/uart.c +++ b/src/cpu/ti/am335x/uart.c @@ -12,7 +12,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <types.h> #include <console/uart.h> #include <device/mmio.h> diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index d87c3d4..91ff14a 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -22,7 +22,6 @@ */
#include <stddef.h> -#include <stdlib.h> #include <string.h> #include <bootstate.h> #include <console/console.h>
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32821 )
Change subject: src/cpu: Use 'include <stdlib.h>' when appropriate ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32821 )
Change subject: src/cpu: Use 'include <stdlib.h>' when appropriate ......................................................................
src/cpu: Use 'include <stdlib.h>' when appropriate
Change-Id: I44346594bc106eed73a1268b82f026b69e5f4512 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32821 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/cpu/allwinner/a10/clock.c M src/cpu/amd/family_10h-family_15h/init_cpus.h M src/cpu/intel/haswell/finalize.c M src/cpu/intel/model_2065x/finalize.c M src/cpu/intel/model_206ax/finalize.c M src/cpu/ti/am335x/gpio.c M src/cpu/ti/am335x/uart.c M src/cpu/x86/mtrr/mtrr.c 8 files changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/cpu/allwinner/a10/clock.c b/src/cpu/allwinner/a10/clock.c index 76198b7..9e4e93d 100644 --- a/src/cpu/allwinner/a10/clock.c +++ b/src/cpu/allwinner/a10/clock.c @@ -22,7 +22,6 @@ #include <console/console.h> #include <delay.h> #include <lib.h> -#include <stdlib.h>
static struct a10_ccm *const ccm = (void *)A1X_CCM_BASE;
diff --git a/src/cpu/amd/family_10h-family_15h/init_cpus.h b/src/cpu/amd/family_10h-family_15h/init_cpus.h index 5d653d1..cca0049 100644 --- a/src/cpu/amd/family_10h-family_15h/init_cpus.h +++ b/src/cpu/amd/family_10h-family_15h/init_cpus.h @@ -16,7 +16,6 @@ #ifndef INIT_CPUS_H #define INIT_CPUS_H
-#include <stdlib.h> #include <cpu/x86/lapic.h> #include <cpu/x86/mtrr.h> #include <cpu/amd/msr.h> diff --git a/src/cpu/intel/haswell/finalize.c b/src/cpu/intel/haswell/finalize.c index cc2d1a4..16e54d7 100644 --- a/src/cpu/intel/haswell/finalize.c +++ b/src/cpu/intel/haswell/finalize.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <arch/cpu.h> #include <cpu/x86/msr.h> #include "haswell.h" diff --git a/src/cpu/intel/model_2065x/finalize.c b/src/cpu/intel/model_2065x/finalize.c index 5b85601..724e09c 100644 --- a/src/cpu/intel/model_2065x/finalize.c +++ b/src/cpu/intel/model_2065x/finalize.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <arch/cpu.h> #include <cpu/x86/msr.h> #include <cpu/intel/speedstep.h> diff --git a/src/cpu/intel/model_206ax/finalize.c b/src/cpu/intel/model_206ax/finalize.c index 30b00bb..98ce555 100644 --- a/src/cpu/intel/model_206ax/finalize.c +++ b/src/cpu/intel/model_206ax/finalize.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <arch/cpu.h> #include <cpu/x86/msr.h> #include <cpu/intel/speedstep.h> diff --git a/src/cpu/ti/am335x/gpio.c b/src/cpu/ti/am335x/gpio.c index 2685839..8660f2c 100644 --- a/src/cpu/ti/am335x/gpio.c +++ b/src/cpu/ti/am335x/gpio.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <cpu/ti/am335x/gpio.h> #include <stdint.h> -#include <stdlib.h>
static struct am335x_gpio_regs *gpio_regs_and_bit(unsigned int gpio, uint32_t *bit) diff --git a/src/cpu/ti/am335x/uart.c b/src/cpu/ti/am335x/uart.c index c482a85..4e9d012 100644 --- a/src/cpu/ti/am335x/uart.c +++ b/src/cpu/ti/am335x/uart.c @@ -12,7 +12,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <types.h> #include <console/uart.h> #include <device/mmio.h> diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index e9efc8b..98449d5 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -22,7 +22,6 @@ */
#include <stddef.h> -#include <stdlib.h> #include <string.h> #include <bootstate.h> #include <commonlib/helpers.h>
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)