[M] Change in coreboot[main]: Choose Correct FW splash screen at runtime

[Shelley Chen (Code Review)]

Attention is currently required from: Andrey Petrov, Julius Werner, Ronak Kanabar, Subrata Banik.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email )

Change subject: Choose Correct FW splash screen at runtime
......................................................................

Patch Set 7:

(4 comments)

This change is ready for review.

File src/lib/Kconfig:

https://review.coreboot.org/c/coreboot/+/79775/comment/f341014f_d74d0205 :
PS6, Line 153: HAVE_CUSTOM_BMP_LOGO
> so, ideally all modern chromeos device should select this Kconfig ? to differentiate between previou […]

The HAVE_CUSTOM_BMP_LOGO config should be automatically selected by the CHROMEOS_FW_SPLASH_SCREEN Kconfig, so the user doesn't need to know about this flag.

My understanding is all modern chromebooks just need:

CONFIG_CHROMEOS_FW_SPLASH_SCREEN=y
CONFIG_CB_LOGO_PATH=<cb_logo_path>
CONFIG_CB_PLUS_LOGO_PATH=<cbplus_logo_path>

old legacy chromebooks would still use the old construct:
CONFIG_BMP_LOGO=y
CONFIG_FSP2_0_LOGO_FILE_NAME=<logo_path>

By legacy device, Subrata, you mean devices that don't have the factory config set correctly, right?

File src/vendorcode/google/chromeos/Kconfig:

https://review.coreboot.org/c/coreboot/+/79775/comment/072c4280_c954b430 :
PS6, Line 95: CBPLUS
> nit: CB_PLUS_LOGO_PATH ?

Sure, I can change it.  I changed all the cbplus_logo references to cb_plus_logo to make it consistent as well.

File src/vendorcode/google/chromeos/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/79775/comment/f30a7400_1bd2fdb4 :
PS6, Line 27: cb_logo.bmp-compression := $(CBFS_COMPRESS_FLAG)
> one blank line between CB and CB_plus assets ?

Done

https://review.coreboot.org/c/coreboot/+/79775/comment/92360227_2d5409a1 :
PS6, Line 33: ramstage-$(CONFIG_CHROMEOS_FW_SPLASH_SCREEN) += splash.c
> may be move this after line 21?

Done