build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29973 )
Change subject: qcs405 [temp]: Combine BB with QC-Sec for ROM boot ......................................................................
Patch Set 4:
(39 comments)
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py File util/qualcomm/createxbl.py:
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@25 PS4, Line 25: # 09/04/15 et Added -x and -d to embed xbl_sec ELF trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@68 PS4, Line 68: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@84 PS4, Line 84: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@103 PS4, Line 103: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@113 PS4, Line 113: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@121 PS4, Line 121: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@144 PS4, Line 144: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@164 PS4, Line 164: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@172 PS4, Line 172: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@192 PS4, Line 192: header_format = 'reg' trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@223 PS4, Line 223: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@231 PS4, Line 231: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@232 PS4, Line 232: # Create hash table trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@235 PS4, Line 235: target_hash, trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@237 PS4, Line 237: secure_type = image_header_secflag) trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@245 PS4, Line 245: target_hash_hd, trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@254 PS4, Line 254: # Add the hash segment into the ELF trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@272 PS4, Line 272: def merge_elfs(env, trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@284 PS4, Line 284: mbn_tools.preprocess_elf_file(elf_in_file_name1) trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@289 PS4, Line 289: mbn_tools.preprocess_elf_file(elf_in_file_name2) trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@290 PS4, Line 290: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@294 PS4, Line 294: mbn_tools.preprocess_elf_file(elf_in_file_xbl_sec) trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@325 PS4, Line 325: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@364 PS4, Line 364: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@400 PS4, Line 400: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@477 PS4, Line 477: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@512 PS4, Line 512: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@614 PS4, Line 614: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@618 PS4, Line 618: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@621 PS4, Line 621: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@640 PS4, Line 640: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@674 PS4, Line 674: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@675 PS4, Line 675: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@681 PS4, Line 681: inp_data_offset = 0 trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@682 PS4, Line 682: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@689 PS4, Line 689: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@706 PS4, Line 706: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/createxbl.py@708 PS4, Line 708: trailing whitespace
https://review.coreboot.org/#/c/29973/4/util/qualcomm/mbn_tools.py File util/qualcomm/mbn_tools.py:
https://review.coreboot.org/#/c/29973/4/util/qualcomm/mbn_tools.py@1167 PS4, Line 1167: # Check if a shifting is required to accomodate for the hash segment. 'accomodate' may be misspelled - perhaps 'accommodate'?
-
build bot (Jenkins) (Code Review)