[XL] Change in coreboot[main]: soc/mediatek/common/dp: Move common functions to dptx_common.c - coreboot-gerrit

7 Jan 2025


      Attention is currently required from: Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85860?usp=email )
Change subject: soc/mediatek/common/dp: Move common functions to dptx_common.c
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/common/dp/dptx_common.c:
https://review.coreboot.org/c/coreboot/+/85860/comment/d70e8801_d91fe81b?usp... :
PS4, Line 281: 	union misc_t dptx_misc;
...
Do you suggest fixing it in a separate patch or in the same patch ?
Separate patch.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85860?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5074feee9efa62f27c118eaf7adb25875ba4c16
Gerrit-Change-Number: 85860
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Tue, 07 Jan 2025 01:32:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com