Change in coreboot[master]: mb/getac/p470: Remove unneeded whitespaces

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

21 Jul 2019 21 Jul '19

3 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34474 )

Change subject: mb/getac/p470: Remove unneeded whitespaces ......................................................................

mb/getac/p470: Remove unneeded whitespaces

Change-Id: I8e36dc1553faa618aa852c06861029b4c0bdb27a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/34474/1

diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb index 3135ac4..9231647 100644 --- a/src/mainboard/getac/p470/devicetree.cb +++ b/src/mainboard/getac/p470/devicetree.cb @@ -54,7 +54,7 @@ register "gpe0_en" = "0x00800106" register "alt_gp_smi_en" = "0x0100"

- register "sata_mode" = "SATA_MODE_IDE_LEGACY_COMBINED" + register "sata_mode" = "SATA_MODE_IDE_LEGACY_COMBINED" register "ide_enable_primary" = "0x1" register "ide_enable_secondary" = "0x0"

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

HAOUAS Elyes (Code Review)

21 Jul 21 Jul

3:02 p.m.

Hello Nico Huber, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34474

to look at the new patch set (#2).

Change subject: mb/getac/p470: Remove unneeded whitespaces ......................................................................

mb/getac/p470: Remove unneeded whitespaces

Change-Id: I8e36dc1553faa618aa852c06861029b4c0bdb27a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/devicetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/34474/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e36dc1553faa618aa852c06861029b4c0bdb27a Gerrit-Change-Number: 34474 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

3:06 p.m.

Hello build bot (Jenkins), Nico Huber, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34474

to look at the new patch set (#3).

Change subject: mb/getac/p470: Remove unneeded whitespaces ......................................................................

mb/getac/p470: Remove unneeded whitespaces

Change-Id: I8e36dc1553faa618aa852c06861029b4c0bdb27a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/devicetree.cb 1 file changed, 30 insertions(+), 30 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/34474/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/34474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e36dc1553faa618aa852c06861029b4c0bdb27a Gerrit-Change-Number: 34474 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Rudolph (Code Review)

22 Jul 22 Jul

8:50 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34474 )

Change subject: mb/getac/p470: Remove unneeded whitespaces ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e36dc1553faa618aa852c06861029b4c0bdb27a Gerrit-Change-Number: 34474 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 22 Jul 2019 06:50:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

25 Jul 25 Jul

6:08 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34474 )

Change subject: mb/getac/p470: Remove unneeded whitespaces ......................................................................

mb/getac/p470: Remove unneeded whitespaces

Change-Id: I8e36dc1553faa618aa852c06861029b4c0bdb27a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/34474 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/getac/p470/devicetree.cb 1 file changed, 30 insertions(+), 30 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved

diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb index 3135ac4..81ee9b1 100644 --- a/src/mainboard/getac/p470/devicetree.cb +++ b/src/mainboard/getac/p470/devicetree.cb @@ -19,21 +19,21 @@ register "gfx.ndid" = "2" register "gfx.did" = "{ 0x80000100, 0x80000410, 0x80000320, 0x80000410, 0x00000005 }"

- device cpu_cluster 0 on - chip cpu/intel/socket_m - device lapic 0 on end - end - end + device cpu_cluster 0 on + chip cpu/intel/socket_m + device lapic 0 on end + end + end

- device domain 0 on - device pci 00.0 on end # host bridge + device domain 0 on + device pci 00.0 on end # host bridge device pci 01.0 off end # i945 PCIe root port device pci 02.0 on end # vga controller device pci 02.1 on end # display controller

- chip southbridge/intel/i82801gx + chip southbridge/intel/i82801gx register "pirqa_routing" = "0x0a" register "pirqb_routing" = "0x0a" register "pirqc_routing" = "0x0a" @@ -54,9 +54,9 @@ register "gpe0_en" = "0x00800106" register "alt_gp_smi_en" = "0x0100"

- register "sata_mode" = "SATA_MODE_IDE_LEGACY_COMBINED" - register "ide_enable_primary" = "0x1" - register "ide_enable_secondary" = "0x0" + register "sata_mode" = "SATA_MODE_IDE_LEGACY_COMBINED" + register "ide_enable_primary" = "0x1" + register "ide_enable_secondary" = "0x0"

register "c3_latency" = "85" register "docking_supported" = "1" @@ -81,8 +81,8 @@ end # PCI bridge device pci 1e.2 off end # AC'97 Audio device pci 1e.3 off end # AC'97 Modem - device pci 1f.0 on # LPC bridge - chip superio/smsc/fdc37n972 + device pci 1f.0 on # LPC bridge + chip superio/smsc/fdc37n972 device pnp 2e.0 off # Floppy end device pnp 2e.1 off # ACPI PM @@ -93,11 +93,11 @@ irq 0x70 = 5 end device pnp 2e.4 on # COM1 - io 0x60 = 0x3f8 - irq 0x70 = 4 + io 0x60 = 0x3f8 + irq 0x70 = 4 end - device pnp 2e.5 off - end + device pnp 2e.5 off + end #device pnp 2e.6 on # RTC # io 0x60 = 0x70 # io 0x62 = 0x74 @@ -109,19 +109,19 @@ end #device pnp 2e.9 on # Mailbox #end - end - chip superio/smsc/sio10n268 - device pnp 4e.0 off # Floppy + end + chip superio/smsc/sio10n268 + device pnp 4e.0 off # Floppy end device pnp 4e.1 off # Parport end #device pnp 4e.2 on # COM3 - # io 0x60 = 0x3e8 - # irq 0x70 = 6 + # io 0x60 = 0x3e8 + # irq 0x70 = 6 #end #device pnp 4e.3 on # COM4 - # io 0x60 = 0x2e8 - # irq 0x70 = 6 + # io 0x60 = 0x2e8 + # irq 0x70 = 6 #end device pnp 4e.5 on # Keyboard io 0x60 = 0x60 @@ -139,12 +139,12 @@ end chip ec/acpi end - end + end

- end + end device pci 1f.1 off end # IDE - device pci 1f.2 on end # SATA - device pci 1f.3 on end # SMBus - end - end + device pci 1f.2 on end # SATA + device pci 1f.3 on end # SMBus + end + end end

-- To view, visit https://review.coreboot.org/c/coreboot/+/34474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e36dc1553faa618aa852c06861029b4c0bdb27a Gerrit-Change-Number: 34474 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1938

days inactive

1942

days old

coreboot-gerrit@coreboot.org

4 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)