Change in coreboot[master]: soc/intel/car/bootblock: Add post-console init callbacks

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36711 )

Change subject: soc/intel/car/bootblock: Add post-console init callbacks
......................................................................

soc/intel/car/bootblock: Add post-console init callbacks

Change-Id: I8f3a1a098fa9f62496b23bf0a6584ab84917521d
Signed-off-by: Arthur Heymans 
---
M src/cpu/intel/car/bootblock.c
M src/cpu/intel/car/bootblock.h
2 files changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/36711/1

diff --git a/src/cpu/intel/car/bootblock.c b/src/cpu/intel/car/bootblock.c
index 664c2b5..063b444 100644
--- a/src/cpu/intel/car/bootblock.c
+++ b/src/cpu/intel/car/bootblock.c
@@ -35,8 +35,16 @@
    bootblock_early_cpu_init();
 }

+void __weak bootblock_northbridge_init(void) { }
+void __weak bootblock_southbridge_init(void) { }
+void __weak bootblock_cpu_init(void) { }
+
 void bootblock_soc_init(void)
 {
    /* Halt if there was a built in self test failure */
    report_bist_failure(saved_bist);
+	/* Post console init */
+	bootblock_northbridge_init();
+	bootblock_southbridge_init();
+	bootblock_cpu_init();
 }
diff --git a/src/cpu/intel/car/bootblock.h b/src/cpu/intel/car/bootblock.h
index 5adfd87..af9e45e 100644
--- a/src/cpu/intel/car/bootblock.h
+++ b/src/cpu/intel/car/bootblock.h
@@ -18,4 +18,8 @@
 void bootblock_early_northbridge_init(void);
 void bootblock_early_southbridge_init(void);

+void bootblock_northbridge_init(void);
+void bootblock_southbridge_init(void);
+void bootblock_cpu_init(void);
+
 #endif

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36711 )

Change subject: soc/intel/car/bootblock: Add post-console init callbacks
......................................................................

Patch Set 5:

I have suggestion to remove intel/car/bootblock.h and looking at it bootblock.c is not intel-specific either.

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36711 )

Change subject: soc/intel/car/bootblock: Add post-console init callbacks
......................................................................

Patch Set 5:

CB:37429 moved intel/car/bootblock.h under arch/.

[Patrick Rudolph (Code Review)]

Attention is currently required from: Arthur Heymans.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36711 )

Change subject: soc/intel/car/bootblock: Add post-console init callbacks
......................................................................

Patch Set 5: Code-Review+2

[S] Change in coreboot[master]: soc/intel/car/bootblock: Add post-console init callbacks

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36711?usp=email )

Change subject: soc/intel/car/bootblock: Add post-console init callbacks
......................................................................

Abandoned