[S] Change in coreboot[master]: mb/google/octopus/variants/phaser: Implement variant_memory_sku() - coreboot-gerrit

24 Nov 2022


      Attention is currently required from: Jamie Chen, Stanley Wu, Marco Chen.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69925 )
Change subject: mb/google/octopus/variants/phaser: Implement variant_memory_sku()
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/octopus/variants/phaser/memory.c:
https://review.coreboot.org/c/coreboot/+/69925/comment/395828a9_e796dbac 
PS4, Line 4: #include <boardid.h>
not used.
https://review.coreboot.org/c/coreboot/+/69925/comment/3577fd5b_8b2671a6 
PS4, Line 6: #include <soc/meminit.h>
not used.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36ec6bad7096e5de666ac6500c8419fc6e383ae1
Gerrit-Change-Number: 69925
Gerrit-PatchSet: 4
Gerrit-Owner: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Jamie Chen jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Joey Peng joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Leo Chou leo.chou@lcfc.corp-partner.google.com
Gerrit-Attention: Jamie Chen jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Marco Chen marcochen@google.com
Gerrit-Comment-Date: Thu, 24 Nov 2022 06:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment