Change in ...coreboot[master]: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint vari...
Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33017
Change subject: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants ......................................................................
mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants
Even fingerprint device probe failed on non-fingerpint boards,the CRFP driver still register the device that cause the GPE#1 as wake source every time. Override devicetree for non-fingerpirnt variants to avoid unexpected wake event(GPE#1).
BUG=b:129650040 BRANCH=firmware-nami-10775.B TEST=Boots to OS and check no GPE#1 wake event from eventlog when S0ix exit.
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: I6fa96e04a34e296889414b96a8c604fc61b8a236 --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33017/1
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index dff62c2..cc87136 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -238,6 +238,7 @@ struct device *root = SA_DEV_ROOT; config_t *cfg = root->chip_info; uint8_t pl2_id = PL2_ID_DEFAULT; + struct device *spi_fpmcu = PCH_DEV_GSPI1;
switch (sku_id) { case SKU_0_SONA: @@ -260,6 +261,7 @@ case SKU_3_PANTHEON: case SKU_4_PANTHEON: cfg->usb2_ports[5].enable = 0; + spi_fpmcu->enabled = 0; break; case SKU_0_BARD: case SKU_1_BARD:
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33017
to look at the new patch set (#2).
Change subject: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants ......................................................................
mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants
Even fingerprint device probe failed on non-fingerpint boards,the CRFP driver still register the device that cause the GPE#1 as wake source every time. Override devicetree for non-fingerpirnt variants to avoid unexpected wake event(GPE#1).
BUG=b:129650040 BRANCH=firmware-nami-10775.108.B TEST=Boots to OS and check no GPE#1 wake event from eventlog when S0ix exit.
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: I6fa96e04a34e296889414b96a8c604fc61b8a236 --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33017/2
EricR Lai has uploaded a new patch set (#3) to the change originally created by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/33017 )
Change subject: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants ......................................................................
mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants
Even fingerprint device probe failed on non-fingerpint boards,the CRFP driver still register the device that cause the GPE#1 as wake source every time. Override devicetree for non-fingerpirnt variants to avoid unexpected wake event(GPE#1).
BUG=b:129650040 BRANCH=firmware-nami-10775.108.B TEST=Boots to OS and check no GPE#1 wake event from eventlog when S0ix exit.
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: I6fa96e04a34e296889414b96a8c604fc61b8a236 --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33017/3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33017 )
Change subject: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants ......................................................................
Patch Set 3: Code-Review+1
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33017 )
Change subject: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33017 )
Change subject: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33017/3/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/#/c/33017/3/src/mainboard/google/poppy/variants/... PS3, Line 264: spi_fpmcu->enabled = 0; Is this really true for all the different SKUs above?
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33017 )
Change subject: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants ......................................................................
Patch Set 3:
Patch Set 3:
(1 comment)
Yes, only EKKO and BARD have fpmcu gpio config in gpio.c. Other SKUs don't have fingerprint.
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33017 )
Change subject: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants ......................................................................
mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants
Even fingerprint device probe failed on non-fingerpint boards,the CRFP driver still register the device that cause the GPE#1 as wake source every time. Override devicetree for non-fingerpirnt variants to avoid unexpected wake event(GPE#1).
BUG=b:129650040 BRANCH=firmware-nami-10775.108.B TEST=Boots to OS and check no GPE#1 wake event from eventlog when S0ix exit.
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: I6fa96e04a34e296889414b96a8c604fc61b8a236 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33017 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: John Su john_su@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified John Su: Looks good to me, approved EricR Lai: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index dff62c2..cc87136 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -238,6 +238,7 @@ struct device *root = SA_DEV_ROOT; config_t *cfg = root->chip_info; uint8_t pl2_id = PL2_ID_DEFAULT; + struct device *spi_fpmcu = PCH_DEV_GSPI1;
switch (sku_id) { case SKU_0_SONA: @@ -260,6 +261,7 @@ case SKU_3_PANTHEON: case SKU_4_PANTHEON: cfg->usb2_ports[5].enable = 0; + spi_fpmcu->enabled = 0; break; case SKU_0_BARD: case SKU_1_BARD:
-
EricR Lai (Code Review) -
Furquan Shaikh (Code Review)
-
Ivy Jian (Code Review)
-
John Su (Code Review)