Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30501 )
Change subject: arch/x86/postcar: Configure MMU along with MTRRs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30501/3/src/arch/x86/postcar_loader.c File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/#/c/30501/3/src/arch/x86/postcar_loader.c@93 PS3, Line 93: */
The main problem I was seeing is that I don't know TOLM or TOM in a platform independent manner. […]
Sounds like it's time to invent common API for TOM and TOLM query then?
The point was, I would rather see any MTRR code if at all possible, and sounds like compulsory pagetable enablement would do it. Better get some other opinions on this though.
-
Kyösti Mälkki (Code Review)