Change in em100[master]: Remove dead assignment

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

27 Jun 2020 27 Jun '20

4:59 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/42843 )

Change subject: Remove dead assignment ......................................................................

Remove dead assignment

Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 --- M firmware.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/43/42843/1

diff --git a/firmware.c b/firmware.c index f86362c..4dc58c0 100644 --- a/firmware.c +++ b/firmware.c @@ -246,7 +246,7 @@ unsigned char page[256], vpage[256]; long fsize; unsigned char *fw; - int i, automatic = 0; + int i; int fpga_offset, fpga_len, mcu_offset, mcu_len; char fpga_version[MAX_VERSION_LENGTH + 1], mcu_version[MAX_VERSION_LENGTH + 1];

Attachments:

attachment.htm (text/html — 2.2 KB)

Show replies by date

HAOUAS Elyes (Code Review)

27 Jun 27 Jun

5:02 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/42843

to look at the new patch set (#2).

Change subject: Remove dead assignment ......................................................................

Remove dead assignment

Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M firmware.c 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/43/42843/2

Angel Pons (Code Review)

28 Jun 28 Jun

11:19 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/42843 )

Change subject: Remove dead assignment ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/em100/+/42843/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/em100/+/42843/2//COMMIT_MSG@7 PS2, Line 7: Remove dead assignment firmware.c: Drop unused but set variable

-- To view, visit https://review.coreboot.org/c/em100/+/42843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Gerrit-Change-Number: 42843 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 28 Jun 2020 11:19:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

29 Jun 29 Jun

6 a.m.

New subject: Change in em100[master]: firmware.c: Remove dead assignment

Hello build bot (Jenkins), Stefan Reinauer, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/42843

to look at the new patch set (#3).

Change subject: firmware.c: Remove dead assignment ......................................................................

firmware.c: Remove dead assignment

Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M firmware.c 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/43/42843/3

-- To view, visit https://review.coreboot.org/c/em100/+/42843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Gerrit-Change-Number: 42843 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

6:06 a.m.

New subject: Change in em100[master]: firmware.c: Fix 'dead increment'

Hello build bot (Jenkins), Stefan Reinauer, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/42843

to look at the new patch set (#4).

Change subject: firmware.c: Fix 'dead increment' ......................................................................

firmware.c: Fix 'dead increment'

Dead increment spotted out using clang-tools.

Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M firmware.c 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/43/42843/4

-- To view, visit https://review.coreboot.org/c/em100/+/42843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Gerrit-Change-Number: 42843 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

6:24 a.m.

New subject: Change in em100[master]: firmware.c: Fix 'dead assignment'

Hello build bot (Jenkins), Stefan Reinauer, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/42843

to look at the new patch set (#5).

Change subject: firmware.c: Fix 'dead assignment' ......................................................................

firmware.c: Fix 'dead assignment'

Dead assignment spotted out using clang-tools.

Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M firmware.c 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/43/42843/5

-- To view, visit https://review.coreboot.org/c/em100/+/42843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Gerrit-Change-Number: 42843 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

3:32 p.m.

New subject: Change in em100[master]: firmware.c: Fix 'dead assignment'

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/42843 )

Change subject: firmware.c: Fix 'dead assignment' ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/em100/+/42843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Gerrit-Change-Number: 42843 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jun 2020 15:32:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

5:45 p.m.

New subject: Change in em100[master]: firmware.c: Fix 'dead assignment'

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/42843 )

Change subject: firmware.c: Fix 'dead assignment' ......................................................................

Patch Set 5: Code-Review+2

Thanks for spotting this.

-- To view, visit https://review.coreboot.org/c/em100/+/42843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Gerrit-Change-Number: 42843 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jun 2020 17:45:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

5:47 p.m.

New subject: Change in em100[master]: firmware.c: Fix 'dead assignment'

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/42843 )

Change subject: firmware.c: Fix 'dead assignment' ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/em100/+/42843/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/em100/+/42843/2//COMMIT_MSG@7 PS2, Line 7: Remove dead assignment

...

firmware. […]

prefix was added, resolving

-- To view, visit https://review.coreboot.org/c/em100/+/42843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Gerrit-Change-Number: 42843 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jun 2020 17:47:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

5:47 p.m.

New subject: Change in em100[master]: firmware.c: Fix 'dead assignment'

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/42843 )

Change subject: firmware.c: Fix 'dead assignment' ......................................................................

firmware.c: Fix 'dead assignment'

Dead assignment spotted out using clang-tools.

Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/em100/+/42843 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M firmware.c 1 file changed, 1 insertion(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Angel Pons: Looks good to me, approved

diff --git a/firmware.c b/firmware.c index f86362c..6bd044e 100644 --- a/firmware.c +++ b/firmware.c @@ -246,7 +246,7 @@ unsigned char page[256], vpage[256]; long fsize; unsigned char *fw; - int i, automatic = 0; + int i; int fpga_offset, fpga_len, mcu_offset, mcu_len; char fpga_version[MAX_VERSION_LENGTH + 1], mcu_version[MAX_VERSION_LENGTH + 1]; @@ -285,7 +285,6 @@ return 0; } memcpy(fw, data.autoupdate_file->address, fsize); - automatic = 1; } else { FILE *f;

-- To view, visit https://review.coreboot.org/c/em100/+/42843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Gerrit-Change-Number: 42843 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1556

days inactive

1558

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Stefan Reinauer (Code Review)