John Zhao has posted comments on this change. ( https://review.coreboot.org/28060 )
Change subject: intel/common/block: Fix issues found by klockwork ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28060/1/src/soc/intel/common/block/cpu/mp_in... File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/#/c/28060/1/src/soc/intel/common/block/cpu/mp_in... PS1, Line 137: assert
I agree with Hannah's approach. […]
While I referred to coreboot_serial.config, it appears CONFIG_FATAL_ASSERTS=y. Then any assert(0) will cause execution halt while booting image.serial.bin(debug). Yes, I agree no execution halt for image.bin(release) since FATAL_ASSERT is not set.
-
John Zhao (Code Review)