Attention is currently required from: Tim Wawrzynczak, Arthur Heymans, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63009 )
Change subject: soc/intel/alderlake: Enable FSP_USES_CB_DEBUG_EVENT_HANDLER Kconfig
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Like to share one observation before we enable this feature on ADL.
Currently we have fixed size cbmem console which is 8K in size and for sure not enough to hold the entire FSP-M debug log (after the CL gets landed). Typically, FSP-M debug log is very detailed and size is significantly high and I'm afraid we might not able to accommodate the same inside `cbmem -c`. I have verified that we are able to contain entire ramstage log inside `cbmem -c` with FSP debug enabled.
config PRERAM_CBMEM_CONSOLE_SIZE
hex
default 0x2000
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63009
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a0530a282657e379a00c3e7d0ed8148dd5e9196
Gerrit-Change-Number: 63009
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 28 Mar 2022 11:48:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment