Change in coreboot[master]: [DONOTSUBMIT]lib: Introduce memory bugs to help test ASan

List overview All Threads
Download

newer

older

Change in coreboot[master]: [WIP]...

Change in coreboot[master]: Fix...

Harshit Sharma (Code Review)

27 Jul 2020 27 Jul '20

1:23 a.m.

Harshit Sharma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT]lib: Introduce memory bugs to help test ASan ......................................................................

[DONOTSUBMIT]lib: Introduce memory bugs to help test ASan

Introduces a few memory bugs into cbfs code to make testing easier for the ones who are willing to try out ASan on their hardware.

Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com --- M src/lib/cbfs.c 1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/43938/1

diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index cb66f81..839de94 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -330,9 +330,30 @@ return 0; }

+#if ENV_RAMSTAGE + int global_array[5] = {-1}; +#endif + int cbfs_boot_region_device(struct region_device *rdev) { + int stack_array[5], i, *p; boot_device_init(); + + /* global out-of-bounds */ +#if ENV_RAMSTAGE + for (i = 10; i > 0; i--) + global_array[i] = i; +#endif + /* stack out-of-bounds */ + for (i = 10; i > 0; i--) + stack_array[i] = i; + + /* use-after-scope */ + { + int x = 5; + p = &x; + } + *p = 10; return vboot_locate_cbfs(rdev) && fmap_locate_area_as_rdev("COREBOOT", rdev); }

Attachments:

attachment.htm (text/html — 3.8 KB)

Show replies by date

Harshit Sharma (Code Review)

27 Jul 27 Jul

1:30 a.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

Harshit Sharma has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

[DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

Introduces a few memory bugs into cbfs code to make testing easier for the ones who are willing to try out ASan on their hardware.

Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com --- M src/lib/cbfs.c 1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/43938/2

Harshit Sharma (Code Review)

10 Aug 10 Aug

6:01 a.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43938

to look at the new patch set (#3).

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

[DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

Introduces a few memory bugs into cbfs code to make testing easier for the ones who are willing to try out ASan on their hardware.

Also, enable ASAN_IN_ROMSTAGE by default on all x86 platforms.

Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com --- M src/Kconfig M src/lib/cbfs.c 2 files changed, 22 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/43938/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

uwe taz (Code Review)

15 Sep 15 Sep

12:57 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 10:57:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

1 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:00:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

1:02 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:02:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

1:03 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:03:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

1:09 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:09:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

1:26 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:26:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

1:26 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:26:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

1:27 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:27:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

1:39 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:39:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Werner Zeh (Code Review)

1:45 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:45:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Werner Zeh (Code Review)

1:46 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 11:46:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

2:10 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3:

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 12:10:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

uwe taz (Code Review)

2:12 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 12:12:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

2:13 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 12:13:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

2:18 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 12:18:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

2:19 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 12:19:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

uwe taz (Code Review)

2:23 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

uwe taz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Patch Set 3: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Name of user not set #1003096 Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 12:23:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Werner Zeh (Code Review)

5:22 p.m.

New subject: Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

Werner Zeh has removed Name of user not set #1003096 from this change. ( https://review.coreboot.org/c/coreboot/+/43938 )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Removed reviewer null with the following votes:

* Verified+1 by Name of user not set (1003096)

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: deleteReviewer

Stefan Reinauer (Code Review)

10 Jun 10 Jun

5:07 a.m.

New subject: [S] Change in coreboot[master]: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43938?usp=email )

Change subject: [DONOTSUBMIT] lib: Introduce memory bugs to help test ASan ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/43938?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0839f2fd2863934ec28e2322bab04b9cc33363b4 Gerrit-Change-Number: 43938 Gerrit-PatchSet: 3 Gerrit-Owner: Harshit Sharma harshitsharmajs@gmail.com Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: uwe taz uwepoeche@arcor.de Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

532

days inactive

1581

days old

coreboot-gerrit@coreboot.org

21 comments

4 participants

tags (0)

participants (4)

Harshit Sharma (Code Review)
Stefan Reinauer (Code Review)
uwe taz (Code Review)
Werner Zeh (Code Review)