Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84922?usp=email )
Change subject: mb/google/nissa/var/riven: Increase the VccIn Aux Imon IccMax to 30A ......................................................................
mb/google/nissa/var/riven: Increase the VccIn Aux Imon IccMax to 30A
From power team's recommendation, increase the VccIn Aux Imon IccMax to 30A to meet HW settings.
BUG=b:376306118 TEST=Build firmware and check the value is changing as expected. Paste the firmware log. [SPEW ] VccInAuxImonIccImax= 0x78 [SPEW ] (MAILBOX) VccInAuxImonIccImax = 120 (1/4 Amp) [INFO ] Override VccInAuxImonIccImax = 120
Change-Id: I71020c2f631cb517a52d4bb65e35277eb731ced7 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84922 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Zhuohao Lee zhuohao@google.com Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/brya/variants/riven/ramstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Zhuohao Lee: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/riven/ramstage.c b/src/mainboard/google/brya/variants/riven/ramstage.c index 5ed9a37f..90517bd 100644 --- a/src/mainboard/google/brya/variants/riven/ramstage.c +++ b/src/mainboard/google/brya/variants/riven/ramstage.c @@ -7,6 +7,6 @@ { /* Refer to FSP Silicon (soc/intel/alderlake/fsp_params.c) VccIn Aux Imon IccMax. Values are in 1/4 Amp increments */ - params->VccInAuxImonIccImax = 100; /* 25000(25A) * 4 / 1000 */ + params->VccInAuxImonIccImax = 120; /* 30000(30A) * 4 / 1000 */ printk(BIOS_INFO, "Override VccInAuxImonIccImax = %d\n", params->VccInAuxImonIccImax); }