Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal, Ivy Jian, Eric Lai, Ronak Kanabar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74161 )
Change subject: soc/intel/meteorlake: Enable VMX
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74161/comment/a01cce33_73c62853
PS3, Line 7: soc/intel/meteorlake: Enable VMX
Yes, reading the commit messages of all the change-sets, it’s clear. […]
Ack
https://review.coreboot.org/c/coreboot/+/74161/comment/d4529ba9_23a9e6ea
PS3, Line 9: This function calls into `set_feature_ctrl_vmx_arg()`
: to enable VMX for virtualization.
This should also be elaborated.
Ack
File src/soc/intel/meteorlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/74161/comment/1bf1c4fa_d3ee62cf
PS3, Line 149: Vmx
VMX
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74161
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e49c15fd4f78a3e633855fea550720f0a685062
Gerrit-Change-Number: 74161
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 12:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment