Change in coreboot[master]: mb/google/octopus/variants/phaser: support new touch panel ic
Rasheed Hsueh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
mb/google/octopus/variants/phaser: support new touch panel ic
This is a new g2touch screen IC, enable touch screen, and ensure it works properly.
BUG=b:171285117 BRANCH=octopus TEST=build bios, check i2c bus and verify touch screen works fine
Change-Id: Ib57597c4998f205c664e13befb4c44532b7dbd4f --- M src/mainboard/google/octopus/variants/phaser/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/48552/1
diff --git a/src/mainboard/google/octopus/variants/phaser/overridetree.cb b/src/mainboard/google/octopus/variants/phaser/overridetree.cb index e25f8fa..466d1fd 100644 --- a/src/mainboard/google/octopus/variants/phaser/overridetree.cb +++ b/src/mainboard/google/octopus/variants/phaser/overridetree.cb @@ -171,6 +171,19 @@ register "has_power_resource" = "1" device i2c 39 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7502"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" + register "generic.enable_delay_ms" = "1" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" + register "generic.reset_delay_ms" = "70" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end end # - I2C 7 end
Hello Henry Sun, Justin TerAvest, Paul Menzel, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48552
to look at the new patch set (#2).
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
mb/google/octopus/variants/phaser: support new touch panel ic
This is a new G2Touch screen IC, enable touch screen, and ensure it works properly.
BUG=b:171285117 BRANCH=octopus TEST=build bios, check i2c bus and verify touch screen works fine
Change-Id: Ib57597c4998f205c664e13befb4c44532b7dbd4f --- M src/mainboard/google/octopus/variants/phaser/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/48552/2
Rasheed Hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
Patch Set 3:
This change is ready for review.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... PS3, Line 182: register "generic.reset_delay_ms" = "70" * I didn't check spec yet and see others set it as 50ms only so may I know where is this 70 came from? * And others also has generic.disable_gpio_export_in_crs?
Rasheed Hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... PS3, Line 182: register "generic.reset_delay_ms" = "70"
- I didn't check spec yet and see others set it as 50ms only so may I know where is this 70 came fro […]
Hi Marco,
I'm referencing this CL: 46344.
Rasheed Hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... PS3, Line 182: register "generic.reset_delay_ms" = "70"
Hi Marco, […]
The reset_delay_ms timing is also from the Vendor adjust, If need I also could provide the reference message on the related issue tracker.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... PS3, Line 182: register "generic.reset_delay_ms" = "70"
The reset_delay_ms timing is also from the Vendor adjust, If need I also could provide the reference […]
* Then please at least add disable_gpio_export_in_crs back to the CL. * And please provide the spec in the issue for the reference.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
Set Ready For Review
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@7 PS3, Line 7: variants variants -> var
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@7 PS3, Line 7: support new touch : panel ic Keep it in single line. Also mention as "Add support for G2TOUCH Touchscreen"
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@10 PS3, Line 10: This is a new G2Touch screen IC, enable touch screen, : and ensure it works properly. Add devicetree configuration for G2TOUCH Touchscreen controller.
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... PS3, Line 182: register "generic.reset_delay_ms" = "70"
- Then please at least add disable_gpio_export_in_crs back to the CL. […]
Since this comment is not resolved, I am re-opening it.
Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Paul Menzel, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48552
to look at the new patch set (#4).
Change subject: mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen ......................................................................
mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen
Add devicetree configuration for G2TOUCH Touchscreen controller.
BUG=b:171285117 BRANCH=octopus TEST=build bios, check i2c bus and verify touch screen works fine
Change-Id: Ib57597c4998f205c664e13befb4c44532b7dbd4f Signed-off-by: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com --- M src/mainboard/google/octopus/variants/phaser/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/48552/4
Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Paul Menzel, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48552
to look at the new patch set (#5).
Change subject: mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen ......................................................................
mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen
Add devicetree configuration for G2TOUCH Touchscreen controller.
BUG=b:175513059 BRANCH=octopus TEST=build bios, check i2c bus and verify touch screen works fine
Change-Id: Ib57597c4998f205c664e13befb4c44532b7dbd4f Signed-off-by: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com --- M src/mainboard/google/octopus/variants/phaser/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/48552/5
Rasheed Hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@7 PS3, Line 7: variants
variants -> var
Done
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@7 PS3, Line 7: support new touch : panel ic
Keep it in single line. […]
Done
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@10 PS3, Line 10: This is a new G2Touch screen IC, enable touch screen, : and ensure it works properly.
Add devicetree configuration for G2TOUCH Touchscreen controller.
Done
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... PS3, Line 182: register "generic.reset_delay_ms" = "70"
Since this comment is not resolved, I am re-opening it.
Yes, Thanks for Macro & Karthik's reminder and reply.
1. disable_gpio_export_in_crs back to the CL. --> done. 2. double confirm on vendor spec & vendor,
70ms is provided by the vendor based on past experience. After checking the spec, this value is not recorded in the datasheet.
I refer to other models that also use the 50ms setting, which is corrected to 50ms.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48552/5/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/5/src/mainboard/google/octopu... PS5, Line 182: "50" In the latest comment in the bug, the vendor is recommending 70 ms.
Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Paul Menzel, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48552
to look at the new patch set (#6).
Change subject: mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen ......................................................................
mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen
Add devicetree configuration for G2TOUCH Touchscreen controller.
BUG=b:175513059 BRANCH=octopus TEST=build bios, check i2c bus and verify touch screen works fine
Change-Id: Ib57597c4998f205c664e13befb4c44532b7dbd4f Signed-off-by: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com --- M src/mainboard/google/octopus/variants/phaser/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/48552/6
rasheed.hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48552/5/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/5/src/mainboard/google/octopu... PS5, Line 182: "50"
In the latest comment in the bug, the vendor is recommending 70 ms.
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen ......................................................................
Patch Set 6: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen ......................................................................
mb/google/octopus/var/phaser: Add support for G2TOUCH Touchscreen
Add devicetree configuration for G2TOUCH Touchscreen controller.
BUG=b:175513059 BRANCH=octopus TEST=build bios, check i2c bus and verify touch screen works fine
Change-Id: Ib57597c4998f205c664e13befb4c44532b7dbd4f Signed-off-by: rasheed.hsueh rasheed.hsueh@lcfc.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48552 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/octopus/variants/phaser/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/phaser/overridetree.cb b/src/mainboard/google/octopus/variants/phaser/overridetree.cb index e25f8fa..fb2936a 100644 --- a/src/mainboard/google/octopus/variants/phaser/overridetree.cb +++ b/src/mainboard/google/octopus/variants/phaser/overridetree.cb @@ -171,6 +171,20 @@ register "has_power_resource" = "1" device i2c 39 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7502"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" + register "generic.enable_delay_ms" = "1" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" + register "generic.reset_delay_ms" = "70" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end end # - I2C 7 end
-
Hung-Te Lin (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Marco Chen (Code Review)
-
Rasheed Hsueh (Code Review)
-
rasheed.hsueh (Code Review)