HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46027 )
Change subject: mb/*/*/acpi: Convert platform.asl to ASL 2.0 syntax ......................................................................
mb/*/*/acpi: Convert platform.asl to ASL 2.0 syntax
Change-Id: I4e7feab6db33427952efa5b6ed6e6d3ae201dcc4 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/butterfly/acpi/platform.asl M src/mainboard/google/link/acpi/platform.asl M src/mainboard/google/parrot/acpi/platform.asl M src/mainboard/google/slippy/acpi/platform.asl M src/mainboard/google/stout/acpi/platform.asl M src/mainboard/intel/cedarisland_crb/acpi/platform.asl M src/mainboard/intel/emeraldlake2/acpi/platform.asl M src/mainboard/kontron/ktqm77/acpi/platform.asl M src/mainboard/lenovo/l520/acpi/platform.asl M src/mainboard/lenovo/s230u/acpi/platform.asl M src/mainboard/lenovo/t420/acpi/platform.asl M src/mainboard/lenovo/t420s/acpi/platform.asl M src/mainboard/lenovo/t430/acpi/platform.asl M src/mainboard/lenovo/t430s/acpi/platform.asl M src/mainboard/lenovo/t440p/acpi/platform.asl M src/mainboard/lenovo/t520/acpi/platform.asl M src/mainboard/lenovo/t530/acpi/platform.asl M src/mainboard/lenovo/x131e/acpi/platform.asl M src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl M src/mainboard/lenovo/x200/acpi/platform.asl M src/mainboard/lenovo/x201/acpi/platform.asl M src/mainboard/lenovo/x220/acpi/platform.asl M src/mainboard/lenovo/x230/acpi/platform.asl M src/mainboard/ocp/deltalake/acpi/platform.asl M src/mainboard/ocp/tiogapass/acpi/platform.asl M src/mainboard/roda/rk9/acpi/platform.asl M src/mainboard/samsung/lumpy/acpi/platform.asl M src/mainboard/samsung/stumpy/acpi/platform.asl 28 files changed, 121 insertions(+), 121 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/46027/1
diff --git a/src/mainboard/google/butterfly/acpi/platform.asl b/src/mainboard/google/butterfly/acpi/platform.asl index f59e485..7c8a815 100644 --- a/src/mainboard/google/butterfly/acpi/platform.asl +++ b/src/mainboard/google/butterfly/acpi/platform.asl @@ -15,16 +15,16 @@ { /* Update in case state changed while asleep */ /* Update AC status */ - Store (_SB.PCI0.LPCB.EC0.ADPT, Local0) - if (LNotEqual (Local0, \PWRS)) { - Store (Local0, \PWRS) + Local0 = _SB.PCI0.LPCB.EC0.ADPT + if (Local0 != \PWRS) { + \PWRS = Local0 Notify (_SB.PCI0.LPCB.EC0.AC, 0x80) }
/* Update LID status */ - Store (_SB.PCI0.LPCB.EC0.LIDF, Local0) - if (LNotEqual (Local0, \LIDS)) { - Store (Local0, \LIDS) + Local0 = _SB.PCI0.LPCB.EC0.LIDF + if (Local0 != \LIDS) { + \LIDS = Local0 Notify (_SB.LID0, 0x80) }
diff --git a/src/mainboard/google/link/acpi/platform.asl b/src/mainboard/google/link/acpi/platform.asl index 35893ee..12b1453 100644 --- a/src/mainboard/google/link/acpi/platform.asl +++ b/src/mainboard/google/link/acpi/platform.asl @@ -7,7 +7,7 @@ Method(_PTS,1) { /* Disable WWAN */ - Store (Zero, GP36) + GP36 = 0 }
/* The _WAK method is called on system wakeup */ @@ -15,16 +15,16 @@ Method(_WAK,1) { /* Update AC status */ - Store (_SB.PCI0.LPCB.EC0.ACEX, Local0) - if (LNotEqual (Local0, \PWRS)) { - Store (Local0, \PWRS) + Local0 = _SB.PCI0.LPCB.EC0.ACEX + if (Local0 != \PWRS) { + \PWRS = Local0 Notify (_SB.PCI0.LPCB.EC0.AC, 0x80) }
/* Update LID status */ - Store (_SB.PCI0.LPCB.EC0.LIDS, Local0) - if (LNotEqual (Local0, \LIDS)) { - Store (Local0, \LIDS) + Local0 = _SB.PCI0.LPCB.EC0.LIDS + if (Local0 != \LIDS) { + \LIDS = Local0 Notify (_SB.PCI0.LPCB.EC0.LID0, 0x80) }
diff --git a/src/mainboard/google/parrot/acpi/platform.asl b/src/mainboard/google/parrot/acpi/platform.asl index 2e14a71..861ba52 100644 --- a/src/mainboard/google/parrot/acpi/platform.asl +++ b/src/mainboard/google/parrot/acpi/platform.asl @@ -15,16 +15,16 @@ { /* Update in case state changed while asleep */ /* Update AC status */ - Store (_SB.PCI0.LPCB.EC0.ADPT, Local0) - if (LNotEqual (Local0, \PWRS)) { - Store (Local0, \PWRS) + Local0 = _SB.PCI0.LPCB.EC0.ADPT + if (Local0 != \PWRS) { + \PWRS = Local0 Notify (_SB.PCI0.LPCB.EC0.AC, 0x80) }
/* Update LID status */ - Store (GP15, Local0) - if (LNotEqual (Local0, \LIDS)) { - Store (Local0, \LIDS) + Local0 = GP15 + if (Local0 != \LIDS) { + \LIDS = Local0 Notify (_SB.LID0, 0x80) }
diff --git a/src/mainboard/google/slippy/acpi/platform.asl b/src/mainboard/google/slippy/acpi/platform.asl index 2813078..a5f343d 100644 --- a/src/mainboard/google/slippy/acpi/platform.asl +++ b/src/mainboard/google/slippy/acpi/platform.asl @@ -15,16 +15,16 @@ Method(_WAK,1) { /* Update AC status */ - Store (_SB.PCI0.LPCB.EC0.ACEX, Local0) - if (LNotEqual (Local0, \PWRS)) { - Store (Local0, \PWRS) + Local0 = _SB.PCI0.LPCB.EC0.ACEX + if (Local0 != \PWRS) { + \PWRS = Local0 Notify (_SB.PCI0.LPCB.EC0.AC, 0x80) }
/* Update LID status */ Store (_SB.PCI0.LPCB.EC0.LIDS, Local0) - if (LNotEqual (Local0, \LIDS)) { - Store (Local0, \LIDS) + if (Local0 != \LIDS) { + \LIDS = Local0 Notify (_SB.PCI0.LPCB.EC0.LID0, 0x80) }
diff --git a/src/mainboard/google/stout/acpi/platform.asl b/src/mainboard/google/stout/acpi/platform.asl index 8220599..b3421d5 100644 --- a/src/mainboard/google/stout/acpi/platform.asl +++ b/src/mainboard/google/stout/acpi/platform.asl @@ -7,7 +7,7 @@ Method(_PTS,1) { // Notify EC to enter S3 - Store(0x01, _SB.PCI0.LPCB.EC0.S3FG) + _SB.PCI0.LPCB.EC0.S3FG = 0x01 }
/* The _WAK method is called on system wakeup */ @@ -15,16 +15,16 @@ Method(_WAK,1) { /* Update AC status */ - Store (_SB.PCI0.LPCB.EC0.ACPW, Local0) - if (LNotEqual (Local0, \PWRS)) { - Store (Local0, \PWRS) + Local0 = _SB.PCI0.LPCB.EC0.ACPW + if (Local0 != \PWRS) { + \PWRS = Local0 Notify (_SB.PCI0.LPCB.EC0.AC, 0x80) }
/* Update LID status */ - Store (NOT(_SB.PCI0.LPCB.EC0.HPLD), Local0) - if (LNotEqual (Local0, \LIDS)) { - Store (Local0, \LIDS) + Local0 = ~_SB.PCI0.LPCB.EC0.HPLD + if (Local0 != \LIDS) { + \LIDS = Local0 Notify (_SB.LID0, 0x80) }
diff --git a/src/mainboard/intel/cedarisland_crb/acpi/platform.asl b/src/mainboard/intel/cedarisland_crb/acpi/platform.asl index 9649592..ebde468 100644 --- a/src/mainboard/intel/cedarisland_crb/acpi/platform.asl +++ b/src/mainboard/intel/cedarisland_crb/acpi/platform.asl @@ -23,7 +23,7 @@
Method(_PIC, 1) { - Store(Arg0, PICM) + PICM = Arg0 }
/* diff --git a/src/mainboard/intel/emeraldlake2/acpi/platform.asl b/src/mainboard/intel/emeraldlake2/acpi/platform.asl index 9568641..9858fda 100644 --- a/src/mainboard/intel/emeraldlake2/acpi/platform.asl +++ b/src/mainboard/intel/emeraldlake2/acpi/platform.asl @@ -8,16 +8,16 @@ { // NVS has a flag to determine USB policy in S3 if (S3U0) { - Store (One, GP47) // Enable USB0 + GP47 = 1 // Enable USB0 } Else { - Store (Zero, GP47) // Disable USB0 + GP47 = 0 // Disable USB0 }
// NVS has a flag to determine USB policy in S3 if (S3U1) { - Store (One, GP56) // Enable USB1 + GP56 = 1 // Enable USB1 } Else { - Store (Zero, GP56) // Disable USB1 + GP56 = 0 // Disable USB1 } }
diff --git a/src/mainboard/kontron/ktqm77/acpi/platform.asl b/src/mainboard/kontron/ktqm77/acpi/platform.asl index cc45619..a0e255c 100644 --- a/src/mainboard/kontron/ktqm77/acpi/platform.asl +++ b/src/mainboard/kontron/ktqm77/acpi/platform.asl @@ -7,7 +7,7 @@ Method(_PTS,1) { /* Let suspend LED flash slowly in S3 and S4 */ - If (LOr (LEqual (Arg0, 3), LEqual (Arg0, 4))) + If ((Arg0 == 3) || (Arg0 == 4)) { _SB.PCI0.LPCB.SIO0.SUSL (0x06) } diff --git a/src/mainboard/lenovo/l520/acpi/platform.asl b/src/mainboard/lenovo/l520/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/l520/acpi/platform.asl +++ b/src/mainboard/lenovo/l520/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/s230u/acpi/platform.asl b/src/mainboard/lenovo/s230u/acpi/platform.asl index 149fb3a..9ad3ff1 100644 --- a/src/mainboard/lenovo/s230u/acpi/platform.asl +++ b/src/mainboard/lenovo/s230u/acpi/platform.asl @@ -3,8 +3,8 @@ Method(_WAK,1) { /* Turn on radios */ - Store (One, GP33) /* WLBT_OFF_5# (To pin 5 of WiFi mPCIe) */ - Store (One, GP36) /* WLBT_OFF_51# (To pin 51 of WiFi mPCIe) */ + GP33 = 1 /* WLBT_OFF_5# (To pin 5 of WiFi mPCIe) */ + GP36 = 1 /* WLBT_OFF_51# (To pin 51 of WiFi mPCIe) */ /* There also is RF_OFF# on pin 20, controlled by the EC */
Return(Package(){0,0}) @@ -13,8 +13,8 @@ Method(_PTS,1) { /* Turn off radios */ - Store (Zero, GP33) /* WLBT_OFF_5# (To pin 5 of WiFi mPCIe) */ - Store (Zero, GP36) /* WLBT_OFF_51# (To pin 51 of WiFi mPCIe) */ + GP33 = 0 /* WLBT_OFF_5# (To pin 5 of WiFi mPCIe) */ + GP36 = 0 /* WLBT_OFF_51# (To pin 51 of WiFi mPCIe) */ /* There also is RF_OFF# on pin 20, controlled by the EC */ }
@@ -22,7 +22,7 @@ { Method(_SST, 1, NotSerialized) { - If (LLess(Arg0, 2)) + If (Arg0 < 2) { /* Thinkpad LED on */ _SB.PCI0.LPCB.EC0.LED (Zero, 0x80) diff --git a/src/mainboard/lenovo/t420/acpi/platform.asl b/src/mainboard/lenovo/t420/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/t420/acpi/platform.asl +++ b/src/mainboard/lenovo/t420/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/t420s/acpi/platform.asl b/src/mainboard/lenovo/t420s/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/t420s/acpi/platform.asl +++ b/src/mainboard/lenovo/t420s/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/t430/acpi/platform.asl b/src/mainboard/lenovo/t430/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/t430/acpi/platform.asl +++ b/src/mainboard/lenovo/t430/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/t430s/acpi/platform.asl b/src/mainboard/lenovo/t430s/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/t430s/acpi/platform.asl +++ b/src/mainboard/lenovo/t430s/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/t440p/acpi/platform.asl b/src/mainboard/lenovo/t440p/acpi/platform.asl index c389fb6..f5a4df7 100644 --- a/src/mainboard/lenovo/t440p/acpi/platform.asl +++ b/src/mainboard/lenovo/t440p/acpi/platform.asl @@ -3,8 +3,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0 Return(Package(){0,0}) }
diff --git a/src/mainboard/lenovo/t520/acpi/platform.asl b/src/mainboard/lenovo/t520/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/t520/acpi/platform.asl +++ b/src/mainboard/lenovo/t520/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/t530/acpi/platform.asl b/src/mainboard/lenovo/t530/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/t530/acpi/platform.asl +++ b/src/mainboard/lenovo/t530/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/x131e/acpi/platform.asl b/src/mainboard/lenovo/x131e/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/x131e/acpi/platform.asl +++ b/src/mainboard/lenovo/x131e/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl +++ b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/x200/acpi/platform.asl b/src/mainboard/lenovo/x200/acpi/platform.asl index 10cadf2..95e594c 100644 --- a/src/mainboard/lenovo/x200/acpi/platform.asl +++ b/src/mainboard/lenovo/x200/acpi/platform.asl @@ -26,12 +26,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
@@ -65,7 +65,7 @@ * running: Windows XP SP1 needs to have C-State coordination * enabled in SMM. */ - If (LAnd(LEqual(OSYS, 2001), MPEN)) { + If ((OSYS == 2001) && MPEN) { // TRAP(61) // TODO }
diff --git a/src/mainboard/lenovo/x201/acpi/platform.asl b/src/mainboard/lenovo/x201/acpi/platform.asl index b03f45f..44b06c6 100644 --- a/src/mainboard/lenovo/x201/acpi/platform.asl +++ b/src/mainboard/lenovo/x201/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) @@ -56,47 +56,47 @@ */
/* Let's assume we're running at least Windows 2000 */ - Store (2000, OSYS) + OSYS = 2000
If (CondRefOf(_OSI)) { If (_OSI("Windows 2001")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2001 SP1")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2001 SP2")) { - Store (2002, OSYS) + OSYS = 2002 }
If (_OSI("Windows 2001.1")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2001.1 SP1")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2006")) { - Store (2006, OSYS) + OSYS = 2006 }
If (_OSI("Windows 2006.1")) { - Store (2006, OSYS) + OSYS = 2006 }
If (_OSI("Windows 2006 SP1")) { - Store (2006, OSYS) + OSYS = 2006 }
If (_OSI("Windows 2009")) { - Store (2009, OSYS) + OSYS = 2009 }
If (_OSI("Windows 2012")) { - Store (2012, OSYS) + OSYS = 2012 } } } diff --git a/src/mainboard/lenovo/x220/acpi/platform.asl b/src/mainboard/lenovo/x220/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/x220/acpi/platform.asl +++ b/src/mainboard/lenovo/x220/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/lenovo/x230/acpi/platform.asl b/src/mainboard/lenovo/x230/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/x230/acpi/platform.asl +++ b/src/mainboard/lenovo/x230/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) diff --git a/src/mainboard/ocp/deltalake/acpi/platform.asl b/src/mainboard/ocp/deltalake/acpi/platform.asl index e04bde5..286cc6c 100644 --- a/src/mainboard/ocp/deltalake/acpi/platform.asl +++ b/src/mainboard/ocp/deltalake/acpi/platform.asl @@ -329,9 +329,9 @@ /* SMI I/O Trap */ Method (TRAP, 1, Serialized) { - Store (Arg0, SMIF) // SMI Function - Store (0, TRP0) // Generate trap - Return (SMIF) // Return value of SMI handler + SMIF = Arg0 // SMI Function + TRP0 = 0 // Generate trap + Return (SMIF) // Return value of SMI handler }
/* @@ -345,7 +345,7 @@ Method (_PIC, 1) { /* Remember the OS' IRQ routing choice. */ - Store (Arg0, PICM) + PICM = Arg0 }
/* diff --git a/src/mainboard/ocp/tiogapass/acpi/platform.asl b/src/mainboard/ocp/tiogapass/acpi/platform.asl index 3398568..02c32f9 100644 --- a/src/mainboard/ocp/tiogapass/acpi/platform.asl +++ b/src/mainboard/ocp/tiogapass/acpi/platform.asl @@ -329,9 +329,9 @@ /* SMI I/O Trap */ Method (TRAP, 1, Serialized) { - Store (Arg0, SMIF) // SMI Function - Store (0, TRP0) // Generate trap - Return (SMIF) // Return value of SMI handler + SMIF = Arg0 // SMI Function + TRP0 = 0 // Generate trap + Return (SMIF) // Return value of SMI handler }
/* @@ -345,7 +345,7 @@ Method (_PIC, 1) { /* Remember the OS' IRQ routing choice. */ - Store (Arg0, PICM) + PICM = Arg0 }
/* diff --git a/src/mainboard/roda/rk9/acpi/platform.asl b/src/mainboard/roda/rk9/acpi/platform.asl index b4d67f5..ee7556c 100644 --- a/src/mainboard/roda/rk9/acpi/platform.asl +++ b/src/mainboard/roda/rk9/acpi/platform.asl @@ -20,12 +20,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
@@ -59,7 +59,7 @@ * running: Windows XP SP1 needs to have C-State coordination * enabled in SMM. */ - If (LAnd(LEqual(OSYS, 2001), MPEN)) { + If ((OSYS == 2001) && MPEN) { // TRAP(61) // TODO }
diff --git a/src/mainboard/samsung/lumpy/acpi/platform.asl b/src/mainboard/samsung/lumpy/acpi/platform.asl index 579308d..0b83f50 100644 --- a/src/mainboard/samsung/lumpy/acpi/platform.asl +++ b/src/mainboard/samsung/lumpy/acpi/platform.asl @@ -6,43 +6,43 @@
Method(_PTS,1) { - Store (Zero, GP35) // Disable WLAN - Store (Zero, GP38) // Disable WWAN + GP35 = 0 // Disable WLAN + GP38 = 0 // Disable WWAN
If (S33G) { - Store (Zero, GP43) // Enable HSPA + GP43 = 0 // Enable HSPA } Else { - Store (One, GP43) // Disable HSPA + GP43 = 1 // Disable HSPA }
- If (LEqual (Arg0, 3)) { + If (Arg0 == 3) { // NVS has a flag to determine USB policy in S3 If (S3U0) { - Store (One, GP47) // Enable USB0 + GP47 = 1 // Enable USB0 } Else { - Store (Zero, GP47) // Disable USB0 + GP47 = 0 // Disable USB0 }
// NVS has a flag to determine USB policy in S3 If (S3U1) { - Store (One, GP56) // Enable USB1 + GP56 = 1 // Enable USB1 } Else { - Store (Zero, GP56) // Disable USB1 + GP56 = 0 // Disable USB1 } } - If (LEqual (Arg0, 5)) { + If (Arg0 == 5) { // NVS has a flag to determine USB policy in S5 If (S5U0) { - Store (One, GP47) // Enable USB0 + GP47 = 1 // Enable USB0 } Else { - Store (Zero, GP47) // Disable USB0 + GP47 = 0 // Disable USB0 }
// NVS has a flag to determine USB policy in S5 If (S5U1) { - Store (One, GP56) // Enable USB1 + GP56 = 1 // Enable USB1 } Else { - Store (Zero, GP56) // Disable USB1 + GP56 = 0 // Disable USB1 } } } @@ -52,10 +52,10 @@ Method(_WAK,1) { /* Update in case state changed while asleep */ - Store (_SB.PCI0.LPCB.EC0.ACEX, \PWRS) + \PWRS = _SB.PCI0.LPCB.EC0.ACEX
/* Enable OS control of fan */ - Store (One, _SB.PCI0.LPCB.EC0.FCOS) + _SB.PCI0.LPCB.EC0.FCOS = 1
Return(Package(){0,0}) } diff --git a/src/mainboard/samsung/stumpy/acpi/platform.asl b/src/mainboard/samsung/stumpy/acpi/platform.asl index 39e414b..ed056db 100644 --- a/src/mainboard/samsung/stumpy/acpi/platform.asl +++ b/src/mainboard/samsung/stumpy/acpi/platform.asl @@ -6,36 +6,36 @@
Method(_PTS,1) { - Store (Zero, GP08) // Disable Bluetooth + GP08 = 0 // Disable Bluetooth
- If (LEqual (Arg0, 3)) { + If (Arg0 == 3) { // NVS has a flag to determine USB policy in S3 If (S3U0) { - Store (One, GP47) // Enable USB0 + GP47 = 1 // Enable USB0 } Else { - Store (Zero, GP47) // Disable USB0 + GP47 = 0 // Disable USB0 }
// NVS has a flag to determine USB policy in S3 If (S3U1) { - Store (One, GP56) // Enable USB1 + GP56 = 1 // Enable USB1 } Else { - Store (Zero, GP56) // Disable USB1 + GP56 = 0 // Disable USB1 } } - If (LEqual (Arg0, 5)) { + If (Arg0 == 5) { // NVS has a flag to determine USB policy in S5 If (S5U0) { - Store (One, GP47) // Enable USB0 + GP47 = 1 // Enable USB0 } Else { - Store (Zero, GP47) // Disable USB0 + GP47 = 0 // Disable USB0 }
// NVS has a flag to determine USB policy in S5 If (S5U1) { - Store (One, GP56) // Enable USB1 + GP56 = 1 // Enable USB1 } Else { - Store (Zero, GP56) // Disable USB1 + GP56 = 0 // Disable USB1 } } } @@ -66,5 +66,5 @@ /* Disable USB Controller Reset in S3 (defaults to enabled) */ Method (USBR, 0, Serialized) { - Store (USB_RESET_DISABLE_MAGIC, US3B) + US3B = USB_RESET_DISABLE_MAGIC }
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46027 )
Change subject: mb/*/*/acpi: Convert platform.asl to ASL 2.0 syntax ......................................................................
Abandoned
squashed
-
HAOUAS Elyes (Code Review)