Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31750 )
Change subject: device/pci_ops: Change ramstage PCI accessor signatures ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31750/1/src/arch/x86/pci_ops_conf1.c File src/arch/x86/pci_ops_conf1.c:
https://review.coreboot.org/#/c/31750/1/src/arch/x86/pci_ops_conf1.c@30 PS1, Line 30: static uint8_t pci_conf1_read_config8(struct device *dev, int where)
shouldn't these be const struct device *? We aren't modifying the device itself.
Yes, then again, followup removes this file entirely.
https://review.coreboot.org/#/c/31750/1/src/device/pci_ops_mmconf.c File src/device/pci_ops_mmconf.c:
https://review.coreboot.org/#/c/31750/1/src/device/pci_ops_mmconf.c@26 PS1, Line 26: #define PCI_MMIO_ADDR(dev, where, mask) \
Can't we just make this an inline function?
Could, removed in followup.
https://review.coreboot.org/#/c/31750/1/src/include/device/pci.h File src/include/device/pci.h:
https://review.coreboot.org/#/c/31750/1/src/include/device/pci.h@38 PS1, Line 38: uint8_t (*read8)(struct device *dev, int where);
const
Changes to pci_devfn_t first, then removed in followups.
-
Kyösti Mälkki (Code Review)