Change in ...coreboot[master]: mb/google/sarien: Disable S5 wake on LAN by default

[EricR Lai (Code Review)]

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32502

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

mb/google/sarien: Disable S5 wake on LAN by default

Chromebook doesn't require support wake on LAN in S5.
Disable it by default for power saving.

BUG=b:131571666
TEST= check LAN indicator is off under S5

Signed-off-by: Eric Lai 
Change-Id: Ia90c9d2f3ea9b3580e9a7bbfb47c917dd51e3c03
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
M src/soc/intel/cannonlake/chip.h
M src/soc/intel/cannonlake/fsp_params.c
3 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/32502/1

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
index 96146ba..0cdd9d0 100644
--- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb
+++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
@@ -52,6 +52,9 @@
    # Enable DDC for DDI port B
    register "DdiPortBDdc" = "1"

+	register "LanWakeFromDeepSx" = "0"
+	register "WolEnableOverride" = "0"
+
    # VR Settings Configuration for 4 Domains
    #+----------------+-------+-------+-------+-------+
    #| Domain/Setting |  SA   |  IA   | GTUS  |  GTS  |
diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h
index 9bba226..ca44085 100644
--- a/src/soc/intel/cannonlake/chip.h
+++ b/src/soc/intel/cannonlake/chip.h
@@ -400,6 +400,8 @@

/* Unlock all GPIO Pads */
    uint8_t PchUnlockGpioPads;
+	uint8_t LanWakeFromDeepSx;
+	uint8_t WolEnableOverride;
 };

typedef struct soc_intel_cannonlake_config config_t;
diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c
index 61d2520..cc01d10 100644
--- a/src/soc/intel/cannonlake/fsp_params.c
+++ b/src/soc/intel/cannonlake/fsp_params.c
@@ -212,6 +212,10 @@
    params->DdiPortDDdc = config->DdiPortDDdc;
    params->DdiPortFDdc = config->DdiPortFDdc;

+	/* WOL */
+	params->PchPmPcieWakeFromDeepSx = config->LanWakeFromDeepSx;
+	params->PchPmWolEnableOverride = config->WolEnableOverride;
+
    /* S0ix */
    params->PchPmSlpS0Enable = config->s0ix_enable;

[EricR Lai (Code Review)]

Hello Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32502

to look at the new patch set (#2).

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

mb/google/sarien: Disable S5 wake on LAN by default

Chromebook doesn't require support wake on LAN in S5.
Disable it by default for power saving.

BUG=b:131571666
TEST=Check LAN indicator is off under S5

Signed-off-by: Eric Lai 
Change-Id: Ia90c9d2f3ea9b3580e9a7bbfb47c917dd51e3c03
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
M src/soc/intel/cannonlake/chip.h
M src/soc/intel/cannonlake/fsp_params.c
3 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/32502/2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32502 )

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

Patch Set 2:

Please help review this

[Simon Glass (Code Review)]

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32502 )

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

Patch Set 2: Code-Review+1

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32502 )

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

Patch Set 2: Code-Review+1

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32502 )

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32502/2/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/32502/2/src/soc/intel/cannonlake/chip.h@403 
PS2, Line 403: 	uint8_t LanWakeFromDeepSx;
             : 	uint8_t WolEnableOverride;
Please add proper comment here for easier user understanding,
https://review.coreboot.org/c/coreboot/+/32368/ can be an example

[EricR Lai (Code Review)]

Hello Patrick Rudolph, Lijian Zhao, Paul Menzel, Duncan Laurie, build bot (Jenkins), Simon Glass,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32502

to look at the new patch set (#3).

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

mb/google/sarien: Disable S5 wake on LAN by default

Chromebook doesn't require support wake on LAN in S5.
Disable it by default for power saving.

BUG=b:131571666
TEST= check LAN indicator is off under S5

Signed-off-by: Eric Lai 
Change-Id: Ia90c9d2f3ea9b3580e9a7bbfb47c917dd51e3c03
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
M src/soc/intel/cannonlake/chip.h
M src/soc/intel/cannonlake/fsp_params.c
3 files changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/32502/3

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32502 )

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32502/2/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/32502/2/src/soc/intel/cannonlake/chip.h@403 
PS2, Line 403: 	uint8_t LanWakeFromDeepSx;
             : 	uint8_t WolEnableOverride;
> Please add proper comment here for easier user understanding, […]

Done

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32502 )

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

Patch Set 3: Code-Review+2

[Simon Glass (Code Review)]

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32502 )

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

Patch Set 3: Code-Review+1

[Simon Glass (Code Review)]

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32502 )

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

Patch Set 3: Code-Review+2

[Duncan Laurie (Code Review)]

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32502 )

Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................

mb/google/sarien: Disable S5 wake on LAN by default

Chromebook doesn't require support wake on LAN in S5.
Disable it by default for power saving.

BUG=b:131571666
TEST= check LAN indicator is off under S5

Signed-off-by: Eric Lai 
Change-Id: Ia90c9d2f3ea9b3580e9a7bbfb47c917dd51e3c03
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32502
Tested-by: build bot (Jenkins) 
Reviewed-by: Lijian Zhao 
Reviewed-by: Simon Glass 
Reviewed-by: Simon Glass 
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
M src/soc/intel/cannonlake/chip.h
M src/soc/intel/cannonlake/fsp_params.c
3 files changed, 11 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Lijian Zhao: Looks good to me, approved
  Simon Glass: Looks good to me, but someone else must approve
  Simon Glass: Looks good to me, approved

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
index 7dd9f15..e9786f1 100644
--- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb
+++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
@@ -53,6 +53,9 @@
    # Enable DDC for DDI port B
    register "DdiPortBDdc" = "1"

+	register "LanWakeFromDeepSx" = "0"
+	register "WolEnableOverride" = "0"
+
    # VR Settings Configuration for 4 Domains
    #+----------------+-------+-------+-------+-------+
    #| Domain/Setting |  SA   |  IA   | GTUS  |  GTS  |
diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h
index 9bba226..40d9f71 100644
--- a/src/soc/intel/cannonlake/chip.h
+++ b/src/soc/intel/cannonlake/chip.h
@@ -400,6 +400,10 @@

/* Unlock all GPIO Pads */
    uint8_t PchUnlockGpioPads;
+
+	/* Enable GBE wakeup */
+	uint8_t LanWakeFromDeepSx;
+	uint8_t WolEnableOverride;
 };

typedef struct soc_intel_cannonlake_config config_t;
diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c
index 61d2520..cc01d10 100644
--- a/src/soc/intel/cannonlake/fsp_params.c
+++ b/src/soc/intel/cannonlake/fsp_params.c
@@ -212,6 +212,10 @@
    params->DdiPortDDdc = config->DdiPortDDdc;
    params->DdiPortFDdc = config->DdiPortFDdc;

+	/* WOL */
+	params->PchPmPcieWakeFromDeepSx = config->LanWakeFromDeepSx;
+	params->PchPmWolEnableOverride = config->WolEnableOverride;
+
    /* S0ix */
    params->PchPmSlpS0Enable = config->s0ix_enable;