Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58899 )
Change subject: [RFC] ChromeOS: Add DECLARE_x_CROS_GPIOS() ......................................................................
Patch Set 3:
(4 comments)
File src/vendorcode/google/chromeos/chromeos.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132184): https://review.coreboot.org/c/coreboot/+/58899/comment/567c9bd3_0f4473da PS3, Line 110: #define DECLARE_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132184): https://review.coreboot.org/c/coreboot/+/58899/comment/2004bbea_0d5a321c PS3, Line 111: const struct cros_gpio *variant_cros_gpios(size_t *num) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132184): https://review.coreboot.org/c/coreboot/+/58899/comment/71ec52dc_10212d94 PS3, Line 117: #define DECLARE_WEAK_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132184): https://review.coreboot.org/c/coreboot/+/58899/comment/7ce64469_f428a492 PS3, Line 118: const struct cros_gpio *__weak variant_cros_gpios(size_t *num) \ please, no space before tabs
-
build bot (Jenkins) (Code Review)