Attention is currently required from: Tim Wawrzynczak, Angel Pons, Subrata Banik, Aamir Bohra.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50880 )
Change subject: intel/fsp2_0: Fix the mp_get_processor_info
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c:
https://review.coreboot.org/c/coreboot/+/50880/comment/c216800e_84994804
PS3, Line 58: get_cpu_core_thread_bits(&core_bits, &thread_bits);
: get_cpu_topology_from_apicid(apicid, core_bits, thread_bits,
: &package, &core, &thread);
This can just be one helper function, right?
```
get_cpu_topology_from_apicid(apicid, &package, &core, &thread);
```
That function can calculate core_bits and thread_bits by itself.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief8677e4830a765af61a0df9621ecaa372730fca
Gerrit-Change-Number: 50880
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Fri, 19 Feb 2021 14:55:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment