Change in coreboot[master]: soc/amd/common/block/update_microcode: Make ucode update more generic - coreboot-gerrit

12 Apr 2022


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63589 )
Change subject: soc/amd/common/block/update_microcode: Make ucode update more generic
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/cpu/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/63589/comment/3f6ce4ae_1d19106a 
PS1, Line 49: CEZANNE_PROC_REV_ID
I'm not a fan of having SoC specific code in common/. What's wrong with keeping CONFIG_SOC_AMD_COMMON_BLOCK_UCODE_SIZE? It's a config parameter for common code.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84a2480cf8274d53ffdab7864135c1bf001241e6
Gerrit-Change-Number: 63589
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 12 Apr 2022 20:04:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment