Change in coreboot[master]: soc/intel/baytrail,braswell: Refactor .post_mp_init

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37131 )

Change subject: soc/intel/baytrail,braswell: Refactor .post_mp_init
......................................................................

soc/intel/baytrail,braswell: Refactor .post_mp_init

Make it consistent with rest of soc/intel.

Change-Id: I42ce0af603f93a074bd629a68223cef88cbc210b
Signed-off-by: Kyösti Mälkki 
---
M src/soc/intel/baytrail/cpu.c
M src/soc/intel/braswell/cpu.c
2 files changed, 12 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37131/1

diff --git a/src/soc/intel/baytrail/cpu.c b/src/soc/intel/baytrail/cpu.c
index d12ece0..2c59531 100644
--- a/src/soc/intel/baytrail/cpu.c
+++ b/src/soc/intel/baytrail/cpu.c
@@ -193,6 +193,11 @@
    smm_state->smbase = staggered_smbase;
 }

+static void post_mp_init(void)
+{
+	smm_southbridge_enable_smi();
+}
+
 static const struct mp_ops mp_ops = {
    .pre_mp_init = pre_mp_init,
    .get_cpu_count = get_cpu_count,
@@ -201,7 +206,7 @@
    .pre_mp_smm_init = smm_southbridge_clear_state,
    .per_cpu_smm_trigger = per_cpu_smm_trigger,
    .relocation_handler = relocation_handler,
-	.post_mp_init = smm_southbridge_enable_smi,
+	.post_mp_init = post_mp_init,
 };

void baytrail_init_cpus(struct device *dev)
diff --git a/src/soc/intel/braswell/cpu.c b/src/soc/intel/braswell/cpu.c
index a44b9cb..33fe685 100644
--- a/src/soc/intel/braswell/cpu.c
+++ b/src/soc/intel/braswell/cpu.c
@@ -208,6 +208,11 @@
    smm_state->smbase = staggered_smbase;
 }

+static void post_mp_init(void)
+{
+	smm_southbridge_enable_smi();
+}
+
 static const struct mp_ops mp_ops = {
    .pre_mp_init = pre_mp_init,
    .get_cpu_count = get_cpu_count,
@@ -216,7 +221,7 @@
    .pre_mp_smm_init = smm_southbridge_clear_state,
    .per_cpu_smm_trigger = per_cpu_smm_trigger,
    .relocation_handler = relocation_handler,
-	.post_mp_init = smm_southbridge_enable_smi,
+	.post_mp_init = post_mp_init,
 };

void soc_init_cpus(struct device *dev)

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37131 )

Change subject: soc/intel/baytrail,braswell: Refactor .post_mp_init
......................................................................

Patch Set 2: Code-Review+2

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37131 )

Change subject: soc/intel/baytrail,braswell: Refactor .post_mp_init
......................................................................

Patch Set 2: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37131 )

Change subject: soc/intel/baytrail,braswell: Refactor .post_mp_init
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37131/2/src/soc/intel/baytrail/cpu.... 
File src/soc/intel/baytrail/cpu.c:

https://review.coreboot.org/c/coreboot/+/37131/2/src/soc/intel/baytrail/cpu.... 
PS2, Line 206: 	.pre_mp_smm_init = smm_southbridge_clear_state,
I will touch this for same reason.

Change in coreboot[master]: soc/intel: Unify em64t100 SMM relocate

[Kyösti Mälkki (Code Review)]

Hello Patrick Rudolph, Arthur Heymans, Marshall Dawson, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37131

to look at the new patch set (#3).

Change subject: soc/intel: Unify em64t100 SMM relocate
......................................................................

soc/intel: Unify em64t100 SMM relocate

Make it consistent with rest of soc/intel. This breaks
the dependency of having to declare a southbridge SMI
function with exact signature of mp_ops callback.

Change-Id: I42ce0af603f93a074bd629a68223cef88cbc210b
Signed-off-by: Kyösti Mälkki 
---
M src/soc/intel/apollolake/cpu.c
M src/soc/intel/baytrail/cpu.c
M src/soc/intel/braswell/cpu.c
M src/soc/intel/denverton_ns/cpu.c
4 files changed, 36 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37131/3

Change in coreboot[master]: soc/intel: Unify em64t100 SMM relocate

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37131 )

Change subject: soc/intel: Unify em64t100 SMM relocate
......................................................................

Abandoned

Change in coreboot[master]: soc/intel: Unify em64t100 SMM relocate

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/37131 )

Change subject: soc/intel: Unify em64t100 SMM relocate
......................................................................

Restored

Change in coreboot[master]: soc/intel: Unify em64t100 SMM relocate

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins), David Guckian, Marshall Dawson, Vanessa Eusebio, Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37131

to look at the new patch set (#5).

Change subject: soc/intel: Unify em64t100 SMM relocate
......................................................................

soc/intel: Unify em64t100 SMM relocate

Make it consistent with rest of soc/intel. This breaks
the dependency of having to declare a southbridge SMI
function with exact signature of mp_ops callback.

Change-Id: I42ce0af603f93a074bd629a68223cef88cbc210b
Signed-off-by: Kyösti Mälkki 
---
M src/soc/intel/apollolake/cpu.c
M src/soc/intel/baytrail/cpu.c
M src/soc/intel/braswell/cpu.c
M src/soc/intel/denverton_ns/cpu.c
4 files changed, 36 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37131/5

Change in coreboot[master]: soc/intel: Unify em64t100 SMM relocate

[David Guckian (Code Review)]

David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37131 )

Change subject: soc/intel: Unify em64t100 SMM relocate
......................................................................

Patch Set 6: Code-Review+1

Change in coreboot[master]: soc/intel: Unify em64t100 SMM relocate

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37131 )

Change subject: soc/intel: Unify em64t100 SMM relocate
......................................................................

Patch Set 7:

This change is ready for review.

Change in coreboot[master]: soc/intel: Unify em64t100 SMM relocate

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37131 )

Change subject: soc/intel: Unify em64t100 SMM relocate
......................................................................

Abandoned