Attention is currently required from: Arthur Heymans, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78895?usp=email )
Change subject: soc/amd/genoa: Add mmio.asl ......................................................................
Patch Set 1:
(3 comments)
File src/soc/amd/genoa/acpi/mmio.asl:
https://review.coreboot.org/c/coreboot/+/78895/comment/09c52404_3adcf9c6 : PS1, Line 199: would be good to have the i2c status reporting code added here too. CB:78900 adds the devicetree ops for that to work; since the acpi table generation isn't enabled yet, the order in this gets added shouldn't really matter though
https://review.coreboot.org/c/coreboot/+/78895/comment/abc1fb94_857dae6f : PS1, Line 322: there are two more i2c devices. CB:78897 adds the missing base address definitions. since we don't have i3c support, i;d say that we shouldn't report the i3c devices in here for now
https://review.coreboot.org/c/coreboot/+/78895/comment/2867e600_351763b2 : PS1, Line 340: 0x0F this should return 0x0b to hide the device in the windows device manager. see CB:68962