Change in coreboot[master]: mb/google/dedede: Enable GBB configs for dedede

[Usha P (Code Review)]

Usha P has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41405 )

Change subject: mb/google/dedede: Enable GBB configs for dedede
......................................................................

mb/google/dedede: Enable GBB configs for dedede

This patch enables the necessary GBB configs for dedede

BUG=none
BRANCH=none
TEST=GBB Flag value was 0x39 before enabling the required flags
and now it is updated to 0x40b9. Verfied from CPU log.

Change-Id: Ica07c65d6cf23ea859de6aa8413377661547e47a
Signed-off-by: Usha P 
---
M src/mainboard/google/dedede/Kconfig
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41405/1

diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig
index 91aeb93..af7a0a4 100644
--- a/src/mainboard/google/dedede/Kconfig
+++ b/src/mainboard/google/dedede/Kconfig
@@ -28,6 +28,10 @@
    bool
    default y
    select EC_GOOGLE_CHROMEEC_SWITCHES
+	select GBB_FLAG_FORCE_DEV_SWITCH_ON
+	select GBB_FLAG_FORCE_DEV_BOOT_USB
+	select GBB_FLAG_FORCE_DEV_BOOT_LEGACY
+	select GBB_FLAG_FORCE_MANUAL_RECOVERY
    select HAS_RECOVERY_MRC_CACHE
    select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
    select VBOOT_LID_SWITCH

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41405 )

Change subject: mb/google/dedede: Enable GBB configs for dedede
......................................................................

Patch Set 1: Code-Review+2

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41405 )

Change subject: mb/google/dedede: Enable GBB configs for dedede
......................................................................

Patch Set 1: Code-Review+2

[Usha P (Code Review)]

Hello build bot (Jenkins), Maulik V Vaghela, Meera Ravindranath, Aamir Bohra, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41405

to look at the new patch set (#2).

Change subject: mb/google/dedede: Enable GBB configs for dedede
......................................................................

mb/google/dedede: Enable GBB configs for dedede

This patch enables the necessary GBB configs for dedede

BUG=none
BRANCH=none
TEST=GBB Flag value was 0x39 before enabling the required flags
and now it is updated to 0x40b9. Verfied from CPU log.

Change-Id: Ica07c65d6cf23ea859de6aa8413377661547e47a
Signed-off-by: Usha P 
---
M src/mainboard/google/dedede/Kconfig
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41405/2

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41405 )

Change subject: mb/google/dedede: Enable GBB configs for dedede
......................................................................

Patch Set 2: Code-Review+2

[Meera Ravindranath (Code Review)]

Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41405 )

Change subject: mb/google/dedede: Enable GBB configs for dedede
......................................................................

Patch Set 2: Code-Review+1

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41405 )

Change subject: mb/google/dedede: Enable GBB configs for dedede
......................................................................

mb/google/dedede: Enable GBB configs for dedede

This patch enables the necessary GBB configs for dedede

BUG=none
BRANCH=none
TEST=GBB Flag value was 0x39 before enabling the required flags
and now it is updated to 0x40b9. Verfied from CPU log.

Change-Id: Ica07c65d6cf23ea859de6aa8413377661547e47a
Signed-off-by: Usha P 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41405
Tested-by: build bot (Jenkins) 
Reviewed-by: Maulik V Vaghela 
Reviewed-by: Meera Ravindranath 
---
M src/mainboard/google/dedede/Kconfig
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Maulik V Vaghela: Looks good to me, approved
  Meera Ravindranath: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig
index 85dbc38e..d9f5ada 100644
--- a/src/mainboard/google/dedede/Kconfig
+++ b/src/mainboard/google/dedede/Kconfig
@@ -29,6 +29,10 @@
    default y
    select EC_GOOGLE_CHROMEEC_SWITCHES
    select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC
+	select GBB_FLAG_FORCE_DEV_SWITCH_ON
+	select GBB_FLAG_FORCE_DEV_BOOT_USB
+	select GBB_FLAG_FORCE_DEV_BOOT_LEGACY
+	select GBB_FLAG_FORCE_MANUAL_RECOVERY
    select VBOOT_LID_SWITCH

config DEVICETREE

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41405 )

Change subject: mb/google/dedede: Enable GBB configs for dedede
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4500
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4499
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4498
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4497

Please note: This test is under development and might not be accurate at all!