Akash Asthana has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27483 )
Change subject: sdm845: Add SPI QUP driver ......................................................................
Patch Set 51:
(3 comments)
Will share the changes with Mike to upload here.
https://review.coreboot.org/#/c/27483/51/src/mainboard/google/cheza/bootbloc... File src/mainboard/google/cheza/bootblock.c:
https://review.coreboot.org/#/c/27483/51/src/mainboard/google/cheza/bootbloc... PS51, Line 19: #include <soc/qcom_qup_se.h>
nit: please order alphabetically
Done
https://review.coreboot.org/#/c/27483/51/src/soc/qualcomm/sdm845/spi_qup.c File src/soc/qualcomm/sdm845/spi_qup.c:
https://review.coreboot.org/#/c/27483/51/src/soc/qualcomm/sdm845/spi_qup.c@1... PS51, Line 150: /n"
I think this is supposed to be a \n?
Done
https://review.coreboot.org/#/c/27483/51/src/soc/qualcomm/sdm845/spi_qup.c@1... PS51, Line 153: }
You should actually return an error value here which you can then pass out of qup_spi_claim_bus().
Done
-
Akash Asthana (Code Review)