Attention is currently required from: Rex-BC Chen, Paul Menzel, Felix Held.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57270 )
Change subject: soc/mediatek: preserve WDT reset reason for debugging
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/57270/comment/68ecc6c8_fef6bd3f
PS6, Line 23: /*
: * We trigger secondary reset by triggering WDT hardware to send signal to EC.
: * We do not use do_board_reset() to send signal to EC
: * which is controlled by software driver.
: */
this comment should be only for MTK_WDT_SWRST_KEY right? or to both wdt_mode and wdt_swrst?
If only for MTK_WDT_SWRST_KEY then please move it to before that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5887a8312f4daab3cbd0a30fea0195670a932e52
Gerrit-Change-Number: 57270
Gerrit-PatchSet: 6
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 03 Sep 2021 07:04:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment