Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table ......................................................................
Patch Set 16:
(3 comments)
File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/35523ee9_08a56639 PS16, Line 49: /* The orientation of the signal follows the orientation of the CC lines. */ : #define SYSINFO_TYPEC_ORIENTATION_FOLLOW_CC 0 : : /* The orientation of the signal is fixed to follow CC1 */ : #define SYSINFO_TYPEC_ORIENTATION_NORMAL 1 : : /* The orientation of the signal is fixed to follow CC2 */ : #define SYSINFO_TYPEC_ORIENTATION_REVERSE 2 Shouldn't this be part of `coreboot_tables.h`?
https://review.coreboot.org/c/coreboot/+/57069/comment/c44353e4_3e5f64bd PS16, Line 172: struct { : uint8_t usb2_port_number; : uint8_t usb3_port_number; : uint8_t sbu_orientation; : uint8_t data_orientation; Can we re-use the struct from `coreboot_tables.h`?
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/d7d7db14_68139065 PS16, Line 263: rec->size = sizeof(*rec); Doesn't this need to include the ports?