Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30852
Change subject: nb/intel/{i945,pineview}: Remove unused function ......................................................................
nb/intel/{i945,pineview}: Remove unused function
Change-Id: I6ca83bde61f231b9f79c90af1d6c1cfa1a027768 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/i945/i945.h M src/northbridge/intel/pineview/pineview.h 2 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/30852/1
diff --git a/src/northbridge/intel/i945/i945.h b/src/northbridge/intel/i945/i945.h index 65a40e7..06414f5 100644 --- a/src/northbridge/intel/i945/i945.h +++ b/src/northbridge/intel/i945/i945.h @@ -371,9 +371,6 @@ void i945_early_initialization(void); void i945_late_initialization(int s3resume);
-/* provided by mainboard code */ -void setup_ich7_gpios(void); - /* debugging functions */ void print_pci_devices(void); void dump_pci_device(unsigned int dev); diff --git a/src/northbridge/intel/pineview/pineview.h b/src/northbridge/intel/pineview/pineview.h index 7378a78..8172bcd 100644 --- a/src/northbridge/intel/pineview/pineview.h +++ b/src/northbridge/intel/pineview/pineview.h @@ -240,9 +240,6 @@ void get_mb_spd_addrmap(u8 *spd_addr_map); void mb_pirq_setup(void); /* optional */
-/* provided by mainboard code */ -void setup_ich7_gpios(void); - struct acpi_rsdp; unsigned long northbridge_write_acpi_tables(unsigned long start, struct acpi_rsdp *rsdp);
Hello Patrick Rudolph, Damien Zammit,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30852
to look at the new patch set (#2).
Change subject: nb/intel/{i945,pineview}: Remove unused function ......................................................................
nb/intel/{i945,pineview}: Remove unused function
Change-Id: I6ca83bde61f231b9f79c90af1d6c1cfa1a027768 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/intel/d510mo/romstage.c M src/northbridge/intel/i945/i945.h M src/northbridge/intel/pineview/pineview.h 3 files changed, 1 insertion(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/30852/2
Hello Patrick Rudolph, build bot (Jenkins), Damien Zammit,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30852
to look at the new patch set (#3).
Change subject: nb/intel/{i945,pineview}: Remove unused function ......................................................................
nb/intel/{i945,pineview}: Remove unused function
Change-Id: I6ca83bde61f231b9f79c90af1d6c1cfa1a027768 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/i945/i945.h M src/northbridge/intel/pineview/pineview.h 2 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/30852/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30852 )
Change subject: nb/intel/{i945,pineview}: Remove unused function ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30852 )
Change subject: nb/intel/{i945,pineview}: Remove unused function ......................................................................
nb/intel/{i945,pineview}: Remove unused function
Change-Id: I6ca83bde61f231b9f79c90af1d6c1cfa1a027768 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/30852 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/i945/i945.h M src/northbridge/intel/pineview/pineview.h 2 files changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/i945/i945.h b/src/northbridge/intel/i945/i945.h index 757eb52..0db07e1 100644 --- a/src/northbridge/intel/i945/i945.h +++ b/src/northbridge/intel/i945/i945.h @@ -371,9 +371,6 @@ void i945_early_initialization(void); void i945_late_initialization(int s3resume);
-/* provided by mainboard code */ -void setup_ich7_gpios(void); - /* debugging functions */ void print_pci_devices(void); void dump_pci_device(unsigned int dev); diff --git a/src/northbridge/intel/pineview/pineview.h b/src/northbridge/intel/pineview/pineview.h index 9873d4d..8c32e17 100644 --- a/src/northbridge/intel/pineview/pineview.h +++ b/src/northbridge/intel/pineview/pineview.h @@ -235,9 +235,6 @@ u32 decode_igd_gtt_size(const u32 gsm); u8 decode_pciebar(u32 *const base, u32 *const len);
-/* provided by mainboard code */ -void setup_ich7_gpios(void); - struct acpi_rsdp; unsigned long northbridge_write_acpi_tables(unsigned long start, struct acpi_rsdp *rsdp);
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Georgi (Code Review)