Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31139
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
lib/hardwaremain: Fix typo ACPI
Change-Id: I51493203b82868d221806c2e22b0c4b62e9fac97 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/lib/hardwaremain.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/31139/1
diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c index e4d5aec..98b8841 100644 --- a/src/lib/hardwaremain.c +++ b/src/lib/hardwaremain.c @@ -458,7 +458,7 @@ post_code(POST_CONSOLE_READY);
/* - * CBMEM needs to be recovered because timestamps, APCI, etc rely on + * CBMEM needs to be recovered because timestamps, ACPI, etc rely on * the cbmem infrastructure being around. Explicitly recover it. */ cbmem_initialize();
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
lib/hardwaremain: Fix typo ACPI
Change-Id: I51493203b82868d221806c2e22b0c4b62e9fac97 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/31139 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/lib/hardwaremain.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c index e4d5aec..98b8841 100644 --- a/src/lib/hardwaremain.c +++ b/src/lib/hardwaremain.c @@ -458,7 +458,7 @@ post_code(POST_CONSOLE_READY);
/* - * CBMEM needs to be recovered because timestamps, APCI, etc rely on + * CBMEM needs to be recovered because timestamps, ACPI, etc rely on * the cbmem infrastructure being around. Explicitly recover it. */ cbmem_initialize();
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
Patch Set 2:
same typo here, isn't it ? src/include/nhlt.h:57 src/mainboard/hp/dl165_g6_fam10/romstage.c:200
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
Patch Set 2:
same typo here, isn't it ? src/include/nhlt.h:57 src/mainboard/hp/dl165_g6_fam10/romstage.c:200
i can take a look
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
Patch Set 2:
same typo here, isn't it ? src/include/nhlt.h:57
https://review.coreboot.org/#/c/coreboot/+/31152/
src/mainboard/hp/dl165_g6_fam10/romstage.c:200
I don;t see any ACPI error here ?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
Patch Set 2:
same typo here, isn't it ? src/include/nhlt.h:57
https://review.coreboot.org/#/c/coreboot/+/31152/
src/mainboard/hp/dl165_g6_fam10/romstage.c:200
I don;t see any ACPI error here ?
"//do we need apci timer, tsc...., only debug need it for better output" shouldn't be : //do we need ACPI ....
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
Patch Set 2:
same typo here, isn't it ? src/include/nhlt.h:57
https://review.coreboot.org/#/c/coreboot/+/31152/
src/mainboard/hp/dl165_g6_fam10/romstage.c:200
I don;t see any ACPI error here ?
"//do we need apci timer, tsc...., only debug need it for better output" shouldn't be : //do we need ACPI ....
Ahh, u r right. updated
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
Patch Set 2:
same typo here, isn't it ? src/include/nhlt.h:57
https://review.coreboot.org/#/c/coreboot/+/31152/
src/mainboard/hp/dl165_g6_fam10/romstage.c:200
I don;t see any ACPI error here ?
"//do we need apci timer, tsc...., only debug need it for better output" shouldn't be : //do we need ACPI ....
Ahh, u r right. updated
one more ?: nano +169 src/southbridge/broadcom/bcm5785/early_setup.c : "// ioapci enable"
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI ......................................................................
Patch Set 2:
same typo here, isn't it ? src/include/nhlt.h:57
https://review.coreboot.org/#/c/coreboot/+/31152/
src/mainboard/hp/dl165_g6_fam10/romstage.c:200
I don;t see any ACPI error here ?
"//do we need apci timer, tsc...., only debug need it for
better
output" shouldn't be : //do we need ACPI ....
Ahh, u r right. updated
one more ?: nano +169 src/southbridge/broadcom/bcm5785/early_setup.c : "// ioapci enable"
yes, should have been IOAPIC
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)