Change in coreboot[master]: mb/facebook/fbg1701: Correct EFP1 configuration

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Frans Hendriks (Code Review)

23 Aug 2019 23 Aug '19

9:36 a.m.

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35043 )

Change subject: mb/facebook/fbg1701: Correct EFP1 configuration ......................................................................

mb/facebook/fbg1701: Correct EFP1 configuration

EFP1 is configured as 'DisplayPort with HDMI/DVI compatibility'. Using this setting 4K monitor is configured into lower resolution. . Change EFP1 setting to 'HDMI/DVI' The next addtional small changes are made in VBT: UEFI GOP Driver Child Device 2 = LFP Child Device 3 = EFP1/LFP LFP Panel configuration Y-Res of Panel #10 = 1920

BUG=N/A TEST=LCD and HDMI on Facebook FBG1701

Change-Id: Idc694b15ff94b83291a8c8252e269b7e6d96f87b Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35043/1

diff --git a/src/mainboard/facebook/fbg1701/data.vbt b/src/mainboard/facebook/fbg1701/data.vbt index 39eba56..356c087 100644 --- a/src/mainboard/facebook/fbg1701/data.vbt +++ b/src/mainboard/facebook/fbg1701/data.vbt Binary files differ

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Frans Hendriks (Code Review)

23 Aug 23 Aug

9:49 a.m.

Hello Patrick Rudolph, Felix Held, Arthur Heymans, Paul Menzel, Lance Zhao, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35043

to look at the new patch set (#2).

Change subject: mb/facebook/fbg1701: Correct EFP1 configuration ......................................................................

mb/facebook/fbg1701: Correct EFP1 configuration

EFP1 is configured as 'DisplayPort with HDMI/DVI compatibility'. Using this setting 4K monitor is configured into lower resolution.

Change EFP1 setting to 'HDMI/DVI' The next addtional small changes are made in VBT: UEFI GOP Driver Child Device 2 = LFP Child Device 3 = EFP1/LFP LFP Panel configuration Y-Res of Panel #10 = 1920

BUG=N/A TEST=LCD and HDMI on Facebook FBG1701

Change-Id: Idc694b15ff94b83291a8c8252e269b7e6d96f87b Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35043/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc694b15ff94b83291a8c8252e269b7e6d96f87b Gerrit-Change-Number: 35043 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Frans Hendriks (Code Review)

10:06 a.m.

New subject: Change in coreboot[master]: mb/facebook/fbg1701/data.vbt: Correct EFP1 configuration

Hello Patrick Rudolph, Felix Held, Arthur Heymans, Paul Menzel, Lance Zhao, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35043

to look at the new patch set (#3).

Change subject: mb/facebook/fbg1701/data.vbt: Correct EFP1 configuration ......................................................................

mb/facebook/fbg1701/data.vbt: Correct EFP1 configuration

EFP1 is configured as 'DisplayPort with HDMI/DVI compatibility'. Using this setting 4K monitor is configured into lower resolution.

Change EFP1 setting to 'HDMI/DVI' The next addtional small changes are made in VBT: UEFI GOP Driver Child Device 2 = LFP Child Device 3 = EFP1/LFP LFP Panel configuration Y-Res of Panel #10 = 1920

BUG=N/A TEST=LCD and HDMI on Facebook FBG1701

Change-Id: Idc694b15ff94b83291a8c8252e269b7e6d96f87b Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35043/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/35043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc694b15ff94b83291a8c8252e269b7e6d96f87b Gerrit-Change-Number: 35043 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Lance Zhao (Code Review)

25 Aug 25 Aug

9:01 a.m.

New subject: Change in coreboot[master]: mb/facebook/fbg1701/data.vbt: Correct EFP1 configuration

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35043 )

Change subject: mb/facebook/fbg1701/data.vbt: Correct EFP1 configuration ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc694b15ff94b83291a8c8252e269b7e6d96f87b Gerrit-Change-Number: 35043 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 25 Aug 2019 09:01:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

26 Aug 26 Aug

1:46 p.m.

New subject: Change in coreboot[master]: mb/facebook/fbg1701/data.vbt: Correct EFP1 configuration

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35043 )

Change subject: mb/facebook/fbg1701/data.vbt: Correct EFP1 configuration ......................................................................

mb/facebook/fbg1701/data.vbt: Correct EFP1 configuration

EFP1 is configured as 'DisplayPort with HDMI/DVI compatibility'. Using this setting 4K monitor is configured into lower resolution.

Change EFP1 setting to 'HDMI/DVI' The next addtional small changes are made in VBT: UEFI GOP Driver Child Device 2 = LFP Child Device 3 = EFP1/LFP LFP Panel configuration Y-Res of Panel #10 = 1920

BUG=N/A TEST=LCD and HDMI on Facebook FBG1701

Change-Id: Idc694b15ff94b83291a8c8252e269b7e6d96f87b Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35043 Reviewed-by: Lance Zhao lance.zhao@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/fbg1701/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Lance Zhao: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/35043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc694b15ff94b83291a8c8252e269b7e6d96f87b Gerrit-Change-Number: 35043 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1916

days inactive

1919

days old

coreboot-gerrit@coreboot.org

4 comments

3 participants

tags (0)

participants (3)

Frans Hendriks (Code Review)
Lance Zhao (Code Review)
Patrick Georgi (Code Review)