Nitheesh Sekar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34931 )
Change subject: qcs405: Add 500 ms delay ......................................................................
qcs405: Add 500 ms delay
Add 500 ms delay before writing the ddr training data to the spi flash. Actual delay has to be calculated based on the calibrations taken during waveforms.
Change-Id: Ic956d73ad39481beadc0f3496c2f643b12694702 Signed-off-by: Nitheesh Sekar nsekar@codeaurora.org --- M src/soc/qualcomm/common/qclib.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34931/1
diff --git a/src/soc/qualcomm/common/qclib.c b/src/soc/qualcomm/common/qclib.c index ac80a76..f8be4f3 100644 --- a/src/soc/qualcomm/common/qclib.c +++ b/src/soc/qualcomm/common/qclib.c @@ -16,6 +16,7 @@ #include <console/cbmem_console.h> #include <cbmem.h> #include <boardid.h> +#include <delay.h> #include <string.h> #include <fmap.h> #include <assert.h> @@ -82,6 +83,8 @@ } else if (!strncmp(QCLIB_TE_DDR_TRAINING_DATA, te->name, sizeof(te->name))) {
+ mdelay(500); //Add 500 ms delay + assert(fmap_overwrite_area(QCLIB_FR_DDR_TRAINING_DATA, (const void *)te->blob_address, te->size));
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34931 )
Change subject: qcs405: Add 500 ms delay ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
https://review.coreboot.org/c/coreboot/+/34931/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34931/1//COMMIT_MSG@7 PS1, Line 7: qcs405: Add 500 ms delay Please be specific:
Delay writing DDR training data to SPI flash
Is that the correct prefix?
https://review.coreboot.org/c/coreboot/+/34931/1//COMMIT_MSG@10 PS1, Line 10: to the spi flash. Actual delay has to be calculated based Why does it need to be delayed?
https://review.coreboot.org/c/coreboot/+/34931/1/src/soc/qualcomm/common/qcl... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/34931/1/src/soc/qualcomm/common/qcl... PS1, Line 86: //Add 500 ms delay Space after `//`. But the comment is useless, as the code is self-explanatory. Please add the reasoning in a comment, why such a long delay is needed.
Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34931 )
Change subject: qcs405: Add 500 ms delay ......................................................................
Abandoned
won't be finished here
-
Nitheesh Sekar (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)