Attention is currently required from: Tim Wawrzynczak, Rizwan Qureshi, Reka Norman, Usha P, Ronak Kanabar, Patrick Rudolph.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61127 )
Change subject: soc/intel/alderlake: Add eMMC ACPI methods for Alder Lake N
......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/alderlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/61127/comment/c4f78f49_9a6ad16b
PS6, Line 21: Name (TEMP, 0)
I don't understand what this is used for. […]
This variable is used to do an additional read to the eMMC controller.
https://review.coreboot.org/c/coreboot/+/61127/comment/a76c27a5_7220b28f
PS6, Line 58: PMCR = PMCR | 0x0003
: TEMP = PMCR
Did you possibly mean this? […]
This is an additional config read to the eMMC controller after the controller has been power gated (put to D3). It is not being used to write back into any registers.
https://review.coreboot.org/c/coreboot/+/23312
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53f04e81584493049d37b46e078d394d3c8a2f09
Gerrit-Change-Number: 61127
Gerrit-PatchSet: 6
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 17 Feb 2022 12:16:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment