Change in coreboot[master]: security/tpm/crtm: Add a function to measure the bootblock on SoC level

[Arthur Heymans (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Christian Walter, Werner Zeh, Fred Reitberger, Andrey Petrov, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64492 )

Change subject: security/tpm/crtm: Add a function to measure the bootblock on SoC level
......................................................................

Patch Set 5: Code-Review+2

(1 comment)

File src/soc/amd/common/block/cpu/noncar/bootblock_measure.c:

https://review.coreboot.org/c/coreboot/+/64492/comment/dbb71369_6ed0b23e 
PS5, Line 5: int tspi_soc_measure_bootblock(int pcr_index)
           : {
           : 	return 1;
           : }
Nit: Add a TODO comment.

I'm split whether it should be returning 0 or 1. 1 is the probably the more correct value, but then nothing else will be measured. OTOH other ROT mechanism might already cover the first code so that 0 is actually fine. Anyway, a real implementation would just measure the cbfsfile "apu/amdfw" in RO so do what you think is best ;-)