Attention is currently required from: Furquan Shaikh, Paul Menzel, Subrata Banik, Angel Pons, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49291 )
Change subject: soc/intel/alderlake: Refactor IGD initialization using FSP UPD
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49291/comment/fd9cf891_42a1b147
PS9, Line 116: params->GraphicsConfigPtr = (uintptr_t)vbt_get();
This is the only thing that changes. Everything else here is already implied
by selecting NO_FSP_GOP. Does it really make a difference? Otherwise, we
could spare us the complexity and leave this file as it is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49291
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbe9c8c4d77018de83815d7d203284b1fbc0da58
Gerrit-Change-Number: 49291
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 18 Jan 2021 22:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment