Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84930?usp=email )
Change subject: soc/mediatek/mt8196: Add SPI driver support
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84930/comment/843fd041_0e443106?usp... :
PS6, Line 9: (
space before `(`
File src/soc/mediatek/mt8196/include/soc/spi.h:
https://review.coreboot.org/c/coreboot/+/84930/comment/a0a0f655_2735db6b?usp... :
PS6, Line 15: #define GET_SCK_REG(x) (x)->spi_cfg2_reg
`Macros with complex values should be enclosed in parentheses`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84930?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10dd1105931c4911ce5257803073b7af76115c75
Gerrit-Change-Number: 84930
Gerrit-PatchSet: 6
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 05 Nov 2024 07:30:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No