Attention is currently required from: Zhuohao Lee, Alan Huang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63191 )
Change subject: mb/google/brya/variants/baseboard/brask: Turn off NFC power in S0ix ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I think we could actually add a "power_gpio" to drivers/usb/acpi/chip. […]
Does the kernel driver support D3cold? Could you try just this instead and see if it will do the same thing?
``` +++ b/src/mainboard/google/brya/variants/brask/overridetree.cb @@ -244,6 +244,8 @@ chip soc/intel/alderlake chip drivers/usb/acpi register "desc" = ""USB2 NFC"" register "type" = "UPC_TYPE_INTERNAL" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D3)" + register "has_power_resource" = "true" device ref usb2_port5 on end end chip drivers/usb/acpi ```