Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Nick Kochlowski.
Anand Vaikar has posted comments on this change by Anand Vaikar. ( https://review.coreboot.org/c/coreboot/+/85865?usp=email )
Change subject: soc/amd/cezanne: Disable I2S internal clock based on mainboard config
......................................................................
Patch Set 3:
(3 comments)
File src/soc/amd/cezanne/chip.h:
https://review.coreboot.org/c/coreboot/+/85865/comment/5449ecee_f76b8664?usp... :
PS2, Line 112:
Remove extra spaces here
Done
File src/soc/amd/cezanne/fch.c:
https://review.coreboot.org/c/coreboot/+/85865/comment/564fc216_666d8ac9?usp... :
PS2, Line 89: /*M
Add space between comment symbols and text, and correct 'disabled'. […]
Done
https://review.coreboot.org/c/coreboot/+/85865/comment/edeaec2c_6701851b?usp... :
PS2, Line 90: used
using?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85865?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0c1bee121f528d28d591dace260507b345dfec26
Gerrit-Change-Number: 85865
Gerrit-PatchSet: 3
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 07 Jan 2025 02:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Kochlowski
nickkochlowski@gmail.com