Attention is currently required from: Angel Pons.
Felix Held has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/74121?usp=email )
Change subject: drivers/option: Add forms in cbtables
......................................................................
Patch Set 30:
(2 comments)
File Documentation/drivers/cfr.md:
https://review.coreboot.org/c/coreboot/+/74121/comment/8eabffee_f52bd973?usp... :
PS30, Line 1: form representation
I think no one bothers to follow up or make new decision, so we decided to get the V1 in with this s […]
this has been discussed in at least one coreboot leadership meeting in 2023 and i think also some separate meeting about this specific topic and i'm reasonably certain that we made the decision to use a different name. i'm not too happy about the fact that we spent time discussing this and the result of that discussion basically got ignored
https://review.coreboot.org/c/coreboot/+/74121/comment/7fca78cb_7c94793d?usp... :
PS30, Line 72:
Sorry I dont get it, what do you mean actually?
the tags should be defined before being referenced. right now some are referenced in the allowed/required sub nodes of other tags before they are defined
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74121?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772
Gerrit-Change-Number: 74121
Gerrit-PatchSet: 30
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Daniel Maslowski
info@orangecms.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 03 Jan 2025 11:28:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lean Sheng Tan
tanleansheng@outlook.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de