Attention is currently required from: David Wu, Tim Wawrzynczak, Nick Vaccaro, Alan Huang, Zhuohao Lee. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60439 )
Change subject: mb/google/brya/var/brask: Change TPM I2C to I2C1 ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60439/comment/367a9715_86ab9cef PS4, Line 9: latest schematics Boards with older schematics were not sold, right?
https://review.coreboot.org/c/coreboot/+/60439/comment/70e6bc97_ac43bc25 PS4, Line 9: The latest schematics changes the TPM I2C from I2C3 to I2C1. : This patch moves the TPM I2C setting from the board layer to the : baseboard and fixes the TPM I2C bus assignment. Please either add a blank line between paragraphs, or reflow for 72 characters per line.
File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60439/comment/4e972149_478c08ad PS4, Line 91: .rise_time_ns = 600, : .fall_time_ns = 400, : .data_hold_time_ns = 50, Where are these values from?
-
Paul Menzel (Code Review)