Attention is currently required from: David Wu, Tim Wawrzynczak, Nick Vaccaro, Alan Huang, Zhuohao Lee.

Patch set 4:Code-Review +1

View Change

3 comments:

• Commit Message:

  • Patch Set #4, Line 9: latest schematics

    Boards with older schematics were not sold, right?

  • Patch Set #4, Line 9:

    The latest schematics changes the TPM I2C from I2C3 to I2C1.
    This patch moves the TPM I2C setting from the board layer to the
    baseboard and fixes the TPM I2C bus assignment.
    

    Please either add a blank line between paragraphs, or reflow for 72 characters per line.

• File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb:

  • Patch Set #4, Line 91:

    .rise_time_ns = 600,
    			.fall_time_ns = 400,
    			.data_hold_time_ns = 50,
    

    Where are these values from?

To view, visit change 60439. To unsubscribe, or for help writing mail filters, visit settings.